Timeline: make prepareHighlightedEntryInfo return ?Promise<!Element>

third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js

 /**
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 197 matching lines @@
      */
     maxStackDepth: function() { },
 
     /**
      * @return {?WebInspector.FlameChart.TimelineData}
      */
     timelineData: function() { },
 
     /**
      * @param {number} entryIndex
-     * @return {?Array.<!{title: string, value: (string|!Element)}>}
+     * @return {?Element}
      */
     prepareHighlightedEntryInfo: function(entryIndex) { },
 
     /**
      * @param {number} entryIndex
      * @return {boolean}
      */
     canJumpToEntry: function(entryIndex) { },
 
     /**
@@ skipping 577 matching lines @@
         this._lastMouseOffsetX = -1;
         this._lastMouseOffsetY = -1;
         this.hideHighlight();
     },
 
     /**
      * @param {number} entryIndex
      */
     _updatePopover: function(entryIndex)
     {
-        if (entryIndex !== this._highlightedEntryIndex) {
-            this._entryInfo.removeChildren();
-            var entryInfo = this._dataProvider.prepareHighlightedEntryInfo(entryIndex);
-            if (entryInfo)
-                this._entryInfo.appendChild(this._buildEntryInfo(entryInfo));
+        if (entryIndex === this._highlightedEntryIndex) {

[alph, 2016/09/08 01:37:46]

You can revert this change.

+            this._updatePopoverOffset();
+            return;
         }
+        this._entryInfo.removeChildren();
+        var popoverElement = this._dataProvider.prepareHighlightedEntryInfo(entryIndex);
+        if (popoverElement) {
+            this._entryInfo.appendChild(popoverElement);
+            this._updatePopoverOffset();
+        }
+    },
+
+    _updatePopoverOffset: function()
+    {
         var mouseX = this._lastMouseOffsetX;
         var mouseY = this._lastMouseOffsetY;
         var parentWidth = this._entryInfo.parentElement.clientWidth;
         var parentHeight = this._entryInfo.parentElement.clientHeight;
         var infoWidth = this._entryInfo.clientWidth;
         var infoHeight = this._entryInfo.clientHeight;
         var /** @const */ offsetX = 10;
         var /** @const */ offsetY = 6;
         var x;
         var y;
@@ skipping 1003 matching lines @@
     /**
      * @param {number} level
      * @return {number}
      */
     _levelToHeight: function(level)
     {
         return this._visibleLevelOffsets[level];
     },
 
     /**
-     * @param {!Array<!{title: string, value: (string|!Element)}>} entryInfo
-     * @return {!Element}
-     */
-    _buildEntryInfo: function(entryInfo)
-    {
-        var infoTable = createElementWithClass("table", "info-table");
-        for (var entry of entryInfo) {
-            var row = infoTable.createChild("tr");
-            row.createChild("td", "title").textContent = entry.title;
-            if (typeof entry.value === "string")
-                row.createChild("td").textContent = entry.value;
-            else
-                row.createChild("td").appendChild(entry.value);
-        }
-        return infoTable;
-    },
-
-    /**
      * @param {!CanvasRenderingContext2D} context
      * @param {string} text
      * @param {number} maxWidth
      * @return {string}
      */
     _prepareText: function(context, text, maxWidth)
     {
         var /** @const */ maxLength = 200;
         if (maxWidth <= 10)
             return "";
@@ skipping 147 matching lines @@
         this.update();
     },
 
     _enabled: function()
     {
         return this._rawTimelineDataLength !== 0;
     },
 
     __proto__: WebInspector.HBox.prototype
 }