Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js

Issue 2314173003: Timeline: make prepareHighlightedEntryInfo return ?Promise<!Element> (Closed)
Patch Set: Timeline: make prepareHighlightEntryInfo return ?Element Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 430 matching lines...) Expand 10 before | Expand all | Expand 10 after
441 /** @type {!Array<!WebInspector.CPUProfileNode>} */ 441 /** @type {!Array<!WebInspector.CPUProfileNode>} */
442 this._entryNodes = entryNodes; 442 this._entryNodes = entryNodes;
443 this._entrySelfTimes = entrySelfTimes; 443 this._entrySelfTimes = entrySelfTimes;
444 444
445 return this._timelineData; 445 return this._timelineData;
446 }, 446 },
447 447
448 /** 448 /**
449 * @override 449 * @override
450 * @param {number} entryIndex 450 * @param {number} entryIndex
451 * @return {?Array<!{title: string, value: (string|!Element)}>} 451 * @return {?Element}
452 */ 452 */
453 prepareHighlightedEntryInfo: function(entryIndex) 453 prepareHighlightedEntryInfo: function(entryIndex)
454 { 454 {
455 var timelineData = this._timelineData; 455 var timelineData = this._timelineData;
456 var node = this._entryNodes[entryIndex]; 456 var node = this._entryNodes[entryIndex];
457 if (!node) 457 if (!node)
458 return null; 458 return null;
459 459
460 var entryInfo = []; 460 var entryInfo = [];
461 /** 461 /**
(...skipping 25 matching lines...) Expand all
487 var linkifier = new WebInspector.Linkifier(); 487 var linkifier = new WebInspector.Linkifier();
488 var link = linkifier.maybeLinkifyConsoleCallFrame(this._target, node.cal lFrame); 488 var link = linkifier.maybeLinkifyConsoleCallFrame(this._target, node.cal lFrame);
489 if (link) 489 if (link)
490 pushEntryInfoRow(WebInspector.UIString("URL"), link.textContent); 490 pushEntryInfoRow(WebInspector.UIString("URL"), link.textContent);
491 linkifier.dispose(); 491 linkifier.dispose();
492 pushEntryInfoRow(WebInspector.UIString("Aggregated self time"), Number.s econdsToString(node.self / 1000, true)); 492 pushEntryInfoRow(WebInspector.UIString("Aggregated self time"), Number.s econdsToString(node.self / 1000, true));
493 pushEntryInfoRow(WebInspector.UIString("Aggregated total time"), Number. secondsToString(node.total / 1000, true)); 493 pushEntryInfoRow(WebInspector.UIString("Aggregated total time"), Number. secondsToString(node.total / 1000, true));
494 if (node.deoptReason) 494 if (node.deoptReason)
495 pushEntryInfoRow(WebInspector.UIString("Not optimized"), node.deoptR eason); 495 pushEntryInfoRow(WebInspector.UIString("Not optimized"), node.deoptR eason);
496 496
497 return entryInfo; 497 return WebInspector.ProfileView.buildPopoverTable(entryInfo);
498 }, 498 },
499 499
500 __proto__: WebInspector.ProfileFlameChartDataProvider.prototype 500 __proto__: WebInspector.ProfileFlameChartDataProvider.prototype
501 } 501 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698