Timeline: make prepareHighlightedEntryInfo return ?Promise<!Element>

Timeline: make prepareHighlightedEntryInfo return ?Promise<!Element>

BUG=

Committed: https://crrev.com/1f84049641ac0f80af74361acd0ea0df338479c4
Cr-Commit-Position: refs/heads/master@{#417475}

[caseq, 2016-09-06 23:45:49]

caseq@chromium.org changed reviewers:
+ alph@chromium.org

[alph, 2016-09-08 00:16:05]

https://codereview.chromium.org/2314173003/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileFlameChart.js
(right):

https://codereview.chromium.org/2314173003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileFlameChart.js:141:
* @return {?Promise<!Element>}
Why is it Promise? I can see it always returns resolved promise.

https://codereview.chromium.org/2314173003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js (right):

https://codereview.chromium.org/2314173003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js:823:
popoverElementPromise.then(element =>
this._entryInfo.appendChild(element)).then(() => this._updatePopoverOffset);
missing a call at the end.

[caseq, 2016-09-08 01:11:07]

ptal

On 2016/09/08 00:16:05, alph wrote:
>
https://codereview.chromium.org/2314173003/diff/1/third_party/WebKit/Source/d...
> File
> third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileFlameChart.js
> (right):
> 
>
https://codereview.chromium.org/2314173003/diff/1/third_party/WebKit/Source/d...
>
third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileFlameChart.js:141:
> * @return {?Promise<!Element>}
> Why is it Promise? I can see it always returns resolved promise.

Because it was required by a subsequent patch. Anyway, returning ?Element now as
we decided not to land that.

[alph, 2016-09-08 01:37:46]

lgtm

https://codereview.chromium.org/2314173003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js (right):

https://codereview.chromium.org/2314173003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js:816: if
(entryIndex === this._highlightedEntryIndex) {
You can revert this change.

[caseq, 2016-09-08 23:05:17]

The CQ bit was checked by caseq@chromium.org

[commit-bot: I haz the power, 2016-09-08 23:05:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 23:14:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 23:14:50]

Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[caseq, 2016-09-09 00:55:39]

The CQ bit was checked by caseq@chromium.org

[commit-bot: I haz the power, 2016-09-09 00:55:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 01:34:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-09 01:37:46]

Description was changed from

==========
Timeline: make prepareHighlightedEntryInfo return ?Promise<!Element>

BUG=
==========

to

==========
Timeline: make prepareHighlightedEntryInfo return ?Promise<!Element>

BUG=

Committed: https://crrev.com/1f84049641ac0f80af74361acd0ea0df338479c4
Cr-Commit-Position: refs/heads/master@{#417475}
==========

[commit-bot: I haz the power, 2016-09-09 01:37:47]

Patchset 2 (id:??) landed as
https://crrev.com/1f84049641ac0f80af74361acd0ea0df338479c4
Cr-Commit-Position: refs/heads/master@{#417475}