Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(928)

Issue 2314163002: Revert of Remove obsolete refs to gyp-[mac|win]-tool (Closed)

Created:
4 years, 3 months ago by scottmg
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Remove obsolete refs to gyp-[mac|win]-tool (patchset #1 id:1 of https://codereview.chromium.org/2299973004/ ) Reason for revert: http://crbug.com/643577 official.desktop.builder Original issue's description: > Remove obsolete refs to gyp-[mac|win]-tool > > R=brettw@chromium.org > BUG=642014 > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/8b48b789b84eef6a433f3c8367f0dadbb04a5f00 TBR=brettw@chromium.org,dpranke@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=642014 Committed: https://chromium.googlesource.com/chromium/tools/build/+/3fcd4ab5eab6c5a08c660da62614257fc768f302

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M scripts/slave/build_directory.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
scottmg
Created Revert of Remove obsolete refs to gyp-[mac|win]-tool
4 years, 3 months ago (2016-09-06 17:31:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2314163002/1
4 years, 3 months ago (2016-09-06 17:31:08 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/3fcd4ab5eab6c5a08c660da62614257fc768f302
4 years, 3 months ago (2016-09-06 17:35:21 UTC) #5
brettw
4 years, 3 months ago (2016-09-06 18:16:01 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698