Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2314043002: Reland of [turbofan] ARM: Implement vswp and use in gap resolver (Closed)

Created:
4 years, 3 months ago by martyn.capewell
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of [turbofan] ARM: Implement vswp and use in gap resolver Reason for revert: Breaks g++ build. Original issue's description: > [turbofan] ARM: Implement vswp and use in gap resolver > > Use vswp to switch double-precision registers in the gap resolver, with fall > back temp register-based code if NEON is not available. > > BUG= > > Committed: https://crrev.com/2837c2e65a2ee5b9fc610f30ce1215f52323ecbd > Cr-Commit-Position: refs/heads/master@{#39209} BUG= Committed: https://crrev.com/c0637c1f23b95816d8b7a3d2a28988cb3a9e6368 Cr-Commit-Position: refs/heads/master@{#39264}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -22 lines) Patch
M src/arm/assembler-arm.h View 2 chunks +4 lines, -1 line 0 comments Download
M src/arm/assembler-arm.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M src/arm/disasm-arm.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm/simulator-arm.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 1 chunk +19 lines, -21 lines 0 comments Download
M test/cctest/test-assembler-arm.cc View 1 chunk +49 lines, -0 lines 0 comments Download
M test/cctest/test-disasm-arm.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
martyn.capewell
Added the missing "U" suffix.
4 years, 3 months ago (2016-09-06 14:55:28 UTC) #2
Michael Achenbach
lgtm (rubber-stamp). Please generally make separate patchsets for the reland and the fix, for easy ...
4 years, 3 months ago (2016-09-06 15:14:20 UTC) #3
martyn.capewell
On 2016/09/06 15:14:20, machenbach (slow) wrote: > lgtm (rubber-stamp). Please generally make separate patchsets for ...
4 years, 3 months ago (2016-09-06 15:58:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2314043002/1
4 years, 3 months ago (2016-09-06 15:58:36 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/23431)
4 years, 3 months ago (2016-09-06 16:10:00 UTC) #8
martyn.capewell
Can I have an lg-tm from an owner, to satisfy presubmit?
4 years, 3 months ago (2016-09-07 12:32:48 UTC) #9
Benedikt Meurer
lgtm
4 years, 3 months ago (2016-09-08 06:44:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2314043002/1
4 years, 3 months ago (2016-09-08 06:44:20 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 07:11:37 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 07:12:26 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c0637c1f23b95816d8b7a3d2a28988cb3a9e6368
Cr-Commit-Position: refs/heads/master@{#39264}

Powered by Google App Engine
This is Rietveld 408576698