Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2314003003: Revert of [turbofan] ARM: Implement vswp and use in gap resolver (Closed)

Created:
4 years, 3 months ago by Michael Achenbach
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] ARM: Implement vswp and use in gap resolver (patchset #2 id:20001 of https://codereview.chromium.org/2313803003/ ) Reason for revert: Breaks arm compilation: https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm%20-%20builder/builds/3549 Original issue's description: > [turbofan] ARM: Implement vswp and use in gap resolver > > Use vswp to switch double-precision registers in the gap resolver, with fall > back temp register-based code if NEON is not available. > > BUG= > > Committed: https://crrev.com/2837c2e65a2ee5b9fc610f30ce1215f52323ecbd > Cr-Commit-Position: refs/heads/master@{#39209} TBR=bmeurer@chromium.org,epertoso@chromium.org,martyn.capewell@arm.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/7e60d08d73d6d6e8300c1237d302fed3d38f2945 Cr-Commit-Position: refs/heads/master@{#39210}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -120 lines) Patch
M src/arm/assembler-arm.h View 2 chunks +1 line, -4 lines 0 comments Download
M src/arm/assembler-arm.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M src/arm/disasm-arm.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/arm/simulator-arm.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 1 chunk +21 lines, -19 lines 0 comments Download
M test/cctest/test-assembler-arm.cc View 1 chunk +0 lines, -49 lines 0 comments Download
M test/cctest/test-disasm-arm.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [turbofan] ARM: Implement vswp and use in gap resolver
4 years, 3 months ago (2016-09-06 14:22:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2314003003/1
4 years, 3 months ago (2016-09-06 14:22:35 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-06 14:22:43 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 14:23:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e60d08d73d6d6e8300c1237d302fed3d38f2945
Cr-Commit-Position: refs/heads/master@{#39210}

Powered by Google App Engine
This is Rietveld 408576698