Rework the cflags test so it works cross platform.

Rework the cflags test so it works cross platform.

Rather than using optimization flags to test cflags,
use our own explicit defined flag.  This is better than
depending on __OPTIMIZE__.

R=phajdan.jr@chromium.org, scottmg@chromium.org

Committed: https://code.google.com/p/gyp/source/detail?r=1698

[scottmg, 2013-08-19 22:59:17]

lgtm

[Paweł Hajdan Jr., 2013-08-19 23:00:09]

LGTM with a comment

https://codereview.chromium.org/23140009/diff/1/test/cflags/gyptest-cflags.py
File test/cflags/gyptest-cflags.py (right):

https://codereview.chromium.org/23140009/diff/1/test/cflags/gyptest-cflags.py...
test/cflags/gyptest-cflags.py:28: if sys.platform.startswith('linux'):
This may now work on Mac, could you check that?

[tony, 2013-08-19 23:09:06]

On 2013/08/19 23:00:09, Paweł Hajdan Jr. wrote:
> LGTM with a comment
> 
> https://codereview.chromium.org/23140009/diff/1/test/cflags/gyptest-cflags.py
> File test/cflags/gyptest-cflags.py (right):
> 
>
https://codereview.chromium.org/23140009/diff/1/test/cflags/gyptest-cflags.py...
> test/cflags/gyptest-cflags.py:28: if sys.platform.startswith('linux'):
> This may now work on Mac, could you check that?

The code doesn't run on Mac.  In ninja.py, the code block is:
if mac:
elif win:
else:
  read CFLAGS/CXXFLAGS/LDFLAGS.

I can do a follow up patch to enable this on Mac.  Should gyp on Windows also
look at the environment variables?

[tony, 2013-08-19 23:13:01]

Committed patchset #2 manually as r1698 (presubmit successful).

[scottmg, 2013-08-19 23:18:27]

On 2013/08/19 23:09:06, tony wrote:
> On 2013/08/19 23:00:09, Paweł Hajdan Jr. wrote:
> > LGTM with a comment
> > 
> >
https://codereview.chromium.org/23140009/diff/1/test/cflags/gyptest-cflags.py
> > File test/cflags/gyptest-cflags.py (right):
> > 
> >
>
https://codereview.chromium.org/23140009/diff/1/test/cflags/gyptest-cflags.py...
> > test/cflags/gyptest-cflags.py:28: if sys.platform.startswith('linux'):
> > This may now work on Mac, could you check that?
> 
> The code doesn't run on Mac.  In ninja.py, the code block is:
> if mac:
> elif win:
> else:
>   read CFLAGS/CXXFLAGS/LDFLAGS.
> 
> I can do a follow up patch to enable this on Mac.  Should gyp on Windows also
> look at the environment variables?

If it's easy, I would say we should make them match. If it's not, then I don't
think it matters much as it's not a commonly-used convention there.