chrome/browser/password_manager/password_manager.h - Issue 23140005: Added of new UMA signals in order to be able to discover early if the "save password" feature gets …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_manager.h

Issue 23140005: Added of new UMA signals in order to be able to discover early if the "save password" feature gets … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review 7 Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/password_manager/password_manager.cc » ('j') | chrome/browser/password_manager/password_manager_delegate_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_manager.h

diff --git a/chrome/browser/password_manager/password_manager.h b/chrome/browser/password_manager/password_manager.h

index 786548d29d806b9e6cb03a4081222d1eb8e42567..52e70d8b2e4ca0aa211a0df59fa0ec8de64e6274 100644

--- a/chrome/browser/password_manager/password_manager.h

+++ b/chrome/browser/password_manager/password_manager.h

@@ -114,7 +114,10 @@ class PasswordManager : public LoginModel,

};

// Log failure for UMA

- void RecordFailure(ProvisionalSaveFailure failure);

+ // |form_origin| is used in order to know if the save password prompt behavior

vabr (Chromium) 2013/09/11 17:31:24 nit: the previous line is wrapped too soon. Just a

jdomingos 2013/09/11 19:15:28 Done.

+ // is monitored for the current host.

+ void RecordFailure(ProvisionalSaveFailure failure,

+ const std::string& form_origin);

// Possibly set up FieldTrial for testing other possible usernames. This only

// happens if there are other_possible_usernames to be shown and the

« no previous file with comments | « no previous file | chrome/browser/password_manager/password_manager.cc » ('j') | chrome/browser/password_manager/password_manager_delegate_impl.cc » ('J')