Added of new UMA signals in order to be able to discover early if the "save password" feature gets …

chrome/browser/password_manager/password_manager_metrics_util_unittest.cc

Index: chrome/browser/password_manager/password_manager_metrics_util_unittest.cc
diff --git a/chrome/browser/password_manager/password_manager_metrics_util_unittest.cc b/chrome/browser/password_manager/password_manager_metrics_util_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..1f9a861d5c86d62bc128307254047e3645acab72
--- /dev/null
+++ b/chrome/browser/password_manager/password_manager_metrics_util_unittest.cc
@@ -0,0 +1,73 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/password_manager/password_manager_metrics_util.h"
+
+#include <iterator>
+#include <map>
+
+#include "base/basictypes.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace {
+
+size_t IsMonitored(const char* url_host) {
+  return password_manager_metrics_util::MonitoredDomainGroupId(url_host);
+}
+
+}  // namespace
+
+TEST(PasswordManagerTest, MonitoredDomainGroupAssigmentTest) {
+  const char* const kMonitoredWebsites[] = {
+      "https://www.google.com",
+      "https://www.yahoo.com",
+      "https://www.baidu.com",
+      "https://www.wikipedia.org",
+      "https://www.linkedin.com",
+      "https://www.twitter.com",
+      "https://www.live.com",
+      "https://www.amazon.com",
+      "https://www.ebay.com",
+      "https://www.tumblr.com",
+  };
+  const size_t kMonitoredWebsitesLength = arraysize(kMonitoredWebsites);
+
+  // The |groups| map contains the group id and the number of times
+  // it get assigned.
+  std::map<size_t, size_t> groups;
+
+  // Provide all possible values of the group id parameter for each monitored
+  // website.
+  for (size_t i = 0; i < kMonitoredWebsitesLength; ++i) {
+    for (size_t j = 0; j < password_manager_metrics_util::kGroupsPerDomain;
+         ++j) {
+      password_manager_metrics_util::SetRandomIdForTesting(j);
+      ++groups[password_manager_metrics_util::MonitoredDomainGroupId(
+            kMonitoredWebsites[i])];
+    }
+  }
+
+  // Check if all groups get assigned the same number of times.
+  size_t number_of_assigment = groups.begin()->second;
+  for (std::map<size_t, size_t>::iterator it = groups.begin();
+       it != groups.end(); ++it) {
+    EXPECT_EQ(it->second, number_of_assigment) << " group id = " << it->first;
+  }
+}
+
+TEST(PasswordManagerTest, MonitoredDomainGroupTest) {
+  size_t group_id;
+  size_t zero = 0;

[vabr (Chromium), 2013/09/12 13:40:02]

Can you delete zero and replace it with 0u?

[jdomingos, 2013/09/12 16:33:52]

Done.

+
+  group_id = IsMonitored("https://www.linkedin.com");
+  EXPECT_GT(group_id, zero);
+  group_id = IsMonitored("https://www.amazon.com");
+  EXPECT_GT(group_id, zero);
+  group_id = IsMonitored("https://www.facebook.com");
+  EXPECT_EQ(group_id, zero);

[vabr (Chromium), 2013/09/12 13:40:02]

If you replace zero with 0u, the please also swap the order to:

EXPECT_EQ(0u, group_id)

because it is the convention to put the expected constant as the first number
for equality checks (not necessarily for GT, but you might also swap that and
replace GT with LT).

Also at the EXPECT_EQ.

[vabr (Chromium), 2013/09/12 13:55:01]

I meant "Also at the EXPECT_EQ below." :)

[jdomingos, 2013/09/12 16:33:52]

Done.

[jdomingos, 2013/09/12 16:33:52]

Done.

+  group_id = IsMonitored("http://wikipedia.org");
+  EXPECT_GT(group_id, zero);
+  group_id = IsMonitored("http://thisisnotwikipedia.org");
+  EXPECT_EQ(group_id, zero);
+}