Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Unified Diff: chrome/browser/password_manager/password_manager.h

Issue 23140005: Added of new UMA signals in order to be able to discover early if the "save password" feature gets … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review 9 Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_manager.h
diff --git a/chrome/browser/password_manager/password_manager.h b/chrome/browser/password_manager/password_manager.h
index 786548d29d806b9e6cb03a4081222d1eb8e42567..527894a36a151185b9edde7102f3a8c7537891e0 100644
--- a/chrome/browser/password_manager/password_manager.h
+++ b/chrome/browser/password_manager/password_manager.h
@@ -113,8 +113,10 @@ class PasswordManager : public LoginModel,
MAX_FAILURE_VALUE
};
- // Log failure for UMA
- void RecordFailure(ProvisionalSaveFailure failure);
+ // Log failure for UMA. Logs additional metrics if the |form_origin|
+ // corresponds to one of the top, explicitly monitored websites.
+ void RecordFailure(ProvisionalSaveFailure failure,
+ const std::string& form_origin);
// Possibly set up FieldTrial for testing other possible usernames. This only
// happens if there are other_possible_usernames to be shown and the

Powered by Google App Engine
This is Rietveld 408576698