Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7773)

Unified Diff: chrome/browser/password_manager/password_manager_delegate_impl.cc

Issue 23140005: Added of new UMA signals in order to be able to discover early if the "save password" feature gets … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review 5 Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_manager_delegate_impl.cc
diff --git a/chrome/browser/password_manager/password_manager_delegate_impl.cc b/chrome/browser/password_manager/password_manager_delegate_impl.cc
index 95ce6b81ab845a42af0b2c5712b4be28dbc1b363..3056eaceca22b3ec01e34a3a54dfb6ccec4601fa 100644
--- a/chrome/browser/password_manager/password_manager_delegate_impl.cc
+++ b/chrome/browser/password_manager/password_manager_delegate_impl.cc
@@ -7,10 +7,12 @@
#include "base/memory/singleton.h"
#include "base/metrics/histogram.h"
#include "base/strings/utf_string_conversions.h"
+#include "base/test/perftimer.h"
#include "chrome/browser/infobars/confirm_infobar_delegate.h"
#include "chrome/browser/infobars/infobar_service.h"
#include "chrome/browser/password_manager/password_form_manager.h"
#include "chrome/browser/password_manager/password_manager.h"
+#include "chrome/browser/password_manager/password_manager_metrics_util.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/sync/one_click_signin_helper.h"
#include "components/autofill/content/browser/autofill_driver_impl.h"
@@ -74,6 +76,13 @@ class SavePasswordInfoBarDelegate : public ConfirmInfoBarDelegate {
// Used to track the results we get from the info bar.
ResponseType infobar_response_;
+ // Save password prompt lifetime needed for a UMA signal.
+ PerfTimer timer_;
+
+ // The domain name corresponding to |form_to_save_| if the form is on
+ // a monitored domain. Otherwise, an empty string.
+ std::string monitored_domain_name_;
+
DISALLOW_COPY_AND_ASSIGN(SavePasswordInfoBarDelegate);
};
@@ -106,11 +115,23 @@ SavePasswordInfoBarDelegate::SavePasswordInfoBarDelegate(
: ConfirmInfoBarDelegate(infobar_service),
form_to_save_(form_to_save),
infobar_response_(NO_RESPONSE) {
+ monitored_domain_name_ = password_manager_metrics_util::IsDomainNameMonitored(
+ form_to_save->realm());
+ if (!monitored_domain_name_.empty()) {
+ password_manager_metrics_util::LogUMAHistogramCount(
+ "PasswordManager.InfobarDisplayed_" + monitored_domain_name_, 1);
+ }
}
SavePasswordInfoBarDelegate::~SavePasswordInfoBarDelegate() {
+
UMA_HISTOGRAM_ENUMERATION("PasswordManager.InfoBarResponse",
infobar_response_, NUM_RESPONSE_TYPES);
+ if (!monitored_domain_name_.empty()) {
+ password_manager_metrics_util::LogUMAHistogramTimes(
+ "PasswordManager.InfoBarResponse_" + monitored_domain_name_,
+ timer_.Elapsed());
+ }
}
int SavePasswordInfoBarDelegate::GetIconID() const {

Powered by Google App Engine
This is Rietveld 408576698