Added of new UMA signals in order to be able to discover early if the "save password" feature gets …

chrome/browser/password_manager/password_manager_metrics_util.h

Index: chrome/browser/password_manager/password_manager_metrics_util.h
diff --git a/chrome/browser/password_manager/password_manager_metrics_util.h b/chrome/browser/password_manager/password_manager_metrics_util.h
new file mode 100644
index 0000000000000000000000000000000000000000..36ef49503de2e31ad08d9138608f4814fe839837
--- /dev/null
+++ b/chrome/browser/password_manager/password_manager_metrics_util.h
@@ -0,0 +1,40 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_MANAGER_METRICS_UTIL_H_
+#define CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_MANAGER_METRICS_UTIL_H_
+
+#include <string>
+
+#include "base/basictypes.h"
+#include "base/metrics/histogram.h"

[Ilya Sherman, 2013/08/30 22:34:42]

nit: Please move this into the .cc file.

[jdomingos, 2013/09/02 09:58:45]

Done.

+
+namespace password_manager_metrics_util {
+
+// Check whether the |url_host| is monitored or not. If yes, we put the
+// domain name into |domain_name|

[Ilya Sherman, 2013/08/30 22:34:42]

Please update this comment.

[jdomingos, 2013/09/02 09:58:45]

Done.

+std::string IsDomainNameMonitored(const std::string& url_host);
+
+// A version of the UMA_HISTOGRAM_ENUMERATION macro that allows the |name|
+// to vary over the program's runtime.
+void LogUMAHistogramEnumeration(const std::string& name,
+                                int sample,
+                                int boundary_value);
+
+// A version of the UMA_HISTOGRAM_TIMES macro that allows the |name|
+// to vary over the program's runtime.
+void LogUMAHistogramTimes(const std::string& name,
+                          const base::TimeDelta& duration);

[Ilya Sherman, 2013/08/30 22:34:42]

nit: You'll need to forward-declare base::TimeDelta, and #include time.h in the
.cc file.

[jdomingos, 2013/09/02 09:58:45]

Done.

+
+// A version of the UMA_HISTOGRAM_COUNT macro that allows the |name|
+// to vary over the program's runtime.
+void LogUMAHistogramCount(const std::string& name, int sample);
+
+// A version of the UMA_HISTOGRAM_BOOLEAN macro that allows the |name|
+// to vary over the program's runtime.
+void LogUMAHistogramBoolean(const std::string& name, bool sample);
+
+}  // namespace password_manager_metrics_util
+
+#endif  // CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_MANAGER_METRICS_UTIL_H_