Added of new UMA signals in order to be able to discover early if the "save password" feature gets …

chrome/browser/password_manager/password_manager_unittest.cc

Index: chrome/browser/password_manager/password_manager_unittest.cc
diff --git a/chrome/browser/password_manager/password_manager_unittest.cc b/chrome/browser/password_manager/password_manager_unittest.cc
index cecba4f5465f19aead9804a1d70dde7cdc3adf46..708459a3f69309c97e73904fd48c8b6626fd7d41 100644
--- a/chrome/browser/password_manager/password_manager_unittest.cc
+++ b/chrome/browser/password_manager/password_manager_unittest.cc
@@ -10,6 +10,7 @@
 #include "chrome/browser/password_manager/mock_password_store.h"
 #include "chrome/browser/password_manager/password_manager.h"
 #include "chrome/browser/password_manager/password_manager_delegate.h"
+#include "chrome/browser/password_manager/password_manager_util.h"
 #include "chrome/browser/password_manager/password_store.h"
 #include "chrome/browser/password_manager/password_store_factory.h"
 #include "chrome/common/pref_names.h"
@@ -536,3 +537,23 @@ TEST_F(PasswordManagerTest, SubmissionCallbackTest) {
   OnPasswordFormSubmitted(form);
   EXPECT_TRUE(FormsAreEqual(form, submitted_form_));
 }
+
+TEST_F(PasswordManagerTest, IsDomainNameMonitoredTest) {
+  std::string domain_name;
+
+  EXPECT_TRUE(password_manager_util::IsDomainNameMonitored(
+      "https://www.linkedin.com", &domain_name));
+  ASSERT_TRUE(domain_name == "linkedin.com");

[Ilya Sherman, 2013/08/29 06:42:21]

nit: EXPECT_EQ

[jdomingos, 2013/08/30 21:09:20]

Done.

+  EXPECT_TRUE(password_manager_util::IsDomainNameMonitored(
+      "https://www.amazon.com", &domain_name));
+  ASSERT_TRUE(domain_name == "amazon.com");
+  EXPECT_FALSE(password_manager_util::IsDomainNameMonitored(
+      "https://www.facebook.com", &domain_name));
+  ASSERT_TRUE(domain_name == "");
+  EXPECT_TRUE(password_manager_util::IsDomainNameMonitored(
+      "wikipedia.org", &domain_name));
+  ASSERT_TRUE(domain_name == "wikipedia.org");
+  EXPECT_FALSE(password_manager_util::IsDomainNameMonitored(
+      "thisisnotwikipedia.org", &domain_name));
+  ASSERT_TRUE(domain_name == "");
+}

[Ilya Sherman, 2013/08/29 06:42:21]

nit: This test should be placed in a file named password_manager_util_unittest.

[jdomingos, 2013/08/30 21:09:20]

Done.