Added of new UMA signals in order to be able to discover early if the "save password" feature gets …

chrome/browser/password_manager/password_manager_delegate_impl.cc

Index: chrome/browser/password_manager/password_manager_delegate_impl.cc
diff --git a/chrome/browser/password_manager/password_manager_delegate_impl.cc b/chrome/browser/password_manager/password_manager_delegate_impl.cc
index 95ce6b81ab845a42af0b2c5712b4be28dbc1b363..5366a457426be6522ccbcc393d362a01299df020 100644
--- a/chrome/browser/password_manager/password_manager_delegate_impl.cc
+++ b/chrome/browser/password_manager/password_manager_delegate_impl.cc
@@ -7,10 +7,12 @@
 #include "base/memory/singleton.h"
 #include "base/metrics/histogram.h"
 #include "base/strings/utf_string_conversions.h"
+#include "base/test/perftimer.h"
 #include "chrome/browser/infobars/confirm_infobar_delegate.h"
 #include "chrome/browser/infobars/infobar_service.h"
 #include "chrome/browser/password_manager/password_form_manager.h"
 #include "chrome/browser/password_manager/password_manager.h"
+#include "chrome/browser/password_manager/password_manager_util.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/sync/one_click_signin_helper.h"
 #include "components/autofill/content/browser/autofill_driver_impl.h"
@@ -53,6 +55,10 @@ class SavePasswordInfoBarDelegate : public ConfirmInfoBarDelegate {
     NUM_RESPONSE_TYPES,
   };
 
+  PerfTimer timer_;

[Garrett Casto, 2013/08/28 01:09:17]

These should be grouped with the other password member variables below.

+
+  std::string domain_name_;
+
   SavePasswordInfoBarDelegate(InfoBarService* infobar_service,
                               PasswordFormManager* form_to_save);
   virtual ~SavePasswordInfoBarDelegate();
@@ -106,11 +112,23 @@ SavePasswordInfoBarDelegate::SavePasswordInfoBarDelegate(
     : ConfirmInfoBarDelegate(infobar_service),
       form_to_save_(form_to_save),
       infobar_response_(NO_RESPONSE) {
+  PasswordManagerUtil::IsDomainNameMonitored(form_to_save->realm(),
+                                             domain_name_);
+  if (domain_name_.size())
+    domain_name_.insert(0, "_");
+  UMA_HISTOGRAM_BOOLEAN("PasswordManager.InfobarDisplayed" + domain_name_,
+                        true);
 }
 
 SavePasswordInfoBarDelegate::~SavePasswordInfoBarDelegate() {
+  // Time which allows us to consider that the info bar has been
+  // displayed during enough time for the user to make a decision.
+  const int kTime = 1000;
   UMA_HISTOGRAM_ENUMERATION("PasswordManager.InfoBarResponse",
                             infobar_response_, NUM_RESPONSE_TYPES);
+  UMA_HISTOGRAM_BOOLEAN(
+      "PasswordManager.InfobarDislayedTooShortly" + domain_name_,

[Garrett Casto, 2013/08/28 01:09:17]

This seems like it would be better as a histogram that displayed the
distribution of infobar times (UMA_HISTOGRAM_TIMES) instead of a boolean stat.

If you keep it as a boolean, I don't think that "too shortly" is grammatically
correct. I would probably say "InfobarDisappearedQuickly".

+      timer_.Elapsed().InMilliseconds() < kTime);
 }
 
 int SavePasswordInfoBarDelegate::GetIconID() const {