Added of new UMA signals in order to be able to discover early if the "save password" feature gets …

chrome/browser/password_manager/password_manager_metrics_util.h

Index: chrome/browser/password_manager/password_manager_metrics_util.h
diff --git a/chrome/browser/password_manager/password_manager_metrics_util.h b/chrome/browser/password_manager/password_manager_metrics_util.h
new file mode 100644
index 0000000000000000000000000000000000000000..e528ec039d44dce3028c887e00b4ae36af433e8a
--- /dev/null
+++ b/chrome/browser/password_manager/password_manager_metrics_util.h
@@ -0,0 +1,49 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_MANAGER_METRICS_UTIL_H_
+#define CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_MANAGER_METRICS_UTIL_H_
+
+#include <string>
+
+namespace password_manager_metrics_util {
+
+// We monitor the performance of the save password heuristic for a handful of
+// domains. For privacy reasons we are not reporting UMA signals by domain, but
+// by a domain group. A domain group can contain multiple domains, and a domain
+// can be contained in multiple groups.
+// For more information see http://goo.gl/vUuFd5.
+
+// The number of groups in which each monitored website appears.
+// It is a half of the total number of groups.
+const size_t kGroupsPerDomain = 10u;
+
+// Check whether the |url_host| is monitored or not. If yes, we return
+// the id of the group which contains the domain name otherwise
+// returns 0.
+size_t MonitoredDomainGroupId(const std::string& url_host);
+
+// A version of the UMA_HISTOGRAM_ENUMERATION macro that allows the |name|
+// to vary over the program's runtime.
+void LogUMAHistogramEnumeration(const std::string& name,
+                                int sample,
+                                int boundary_value);
+
+// A version of the UMA_HISTOGRAM_BOOLEAN macro that allows the |name|
+// to vary over the program's runtime.
+void LogUMAHistogramBoolean(const std::string& name, bool sample);
+
+// Sets the |kGroupsPerDomain| to |value|. Needed in order to test the

[Ilya Sherman, 2013/09/14 03:33:25]

|kGroupsPerDomain| is a constant, not a variable, so you can't set it to some
other value.  I think you meant |g_random_group_id|... but since that's an
implementation detail that's not exposed in the header file, it would be better
to say something like "Sets the random seed used to generate group ids for
monitored domains".

+// MonitoredDomainGroupId function with all possible values of
+// |kGroupsPerDomain|. Normally,the value of |kGroupsPerDomain| is
+// randomly generated in range [0, |kGroupsPerDomain|).
+void SetRandomIdForTesting(size_t value);
+
+// Returns a string which contains group_|group_id|. If the
+// group_id corresponds to an unmonitored domain returns an empty string.
+std::string GroupIdToString(size_t group_id);
+
+}  // namespace password_manager_metrics_util
+
+#endif  // CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_MANAGER_METRICS_UTIL_H_