Added of new UMA signals in order to be able to discover early if the "save password" feature gets …

chrome/browser/password_manager/password_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_MANAGER_H_
 #define CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_MANAGER_H_
 
 #include <vector>
 
 #include "base/callback.h"
@@ skipping 95 matching lines @@
     SAVING_DISABLED,
     EMPTY_PASSWORD,
     NO_MATCHING_FORM,
     MATCHING_NOT_COMPLETE,
     FORM_BLACKLISTED,
     INVALID_FORM,
     AUTOCOMPLETE_OFF,
     MAX_FAILURE_VALUE
   };
 
-  // Log failure for UMA
-  void RecordFailure(ProvisionalSaveFailure failure);
+  // Log failure for UMA. |form_origin| is used in order to know if the save
+  // password prompt behavior is monitored for the current host.

[Ilya Sherman, 2013/09/12 04:45:45]

I find the second sentence in this comment somewhat hard to follow.  One
possible rephrasing that I think would be clearer: "Logs additional metrics if
the |form_origin| corresponds to one of the top, explicitly monitored websites."

[jdomingos, 2013/09/12 12:01:01]

Done.

+  void RecordFailure(ProvisionalSaveFailure failure,
+                     const std::string& form_origin);
 
   // Possibly set up FieldTrial for testing other possible usernames. This only
   // happens if there are other_possible_usernames to be shown and the
   // experiment hasn't already been initialized. We setup the experiment at
   // such a late time because this experiment will only affect a small number
   // of users so we want to include a larger fraction of these users than the
   // normal 10%.
   void PossiblyInitializeUsernamesExperiment(
       const autofill::PasswordFormMap& matches) const;
 
@@ skipping 41 matching lines @@
   // notification in const member functions.
   mutable ObserverList<LoginModelObserver> observers_;
 
   // Callbacks to be notified when a password form has been submitted.
   std::vector<PasswordSubmittedCallback> submission_callbacks_;
 
   DISALLOW_COPY_AND_ASSIGN(PasswordManager);
 };
 
 #endif  // CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_MANAGER_H_