Added of new UMA signals in order to be able to discover early if the "save password" feature gets …

chrome/browser/password_manager/password_manager_metrics_util.cc

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/password_manager/password_manager_metrics_util.h"
+
+#include "base/basictypes.h"
+#include "base/metrics/histogram.h"
+#include "base/process/process_handle.h"
+#include "base/rand_util.h"
+#include "base/strings/string_number_conversions.h"
+#include "base/strings/string_util.h"
+#include "base/time/time.h"
+#include "url/gurl.h"
+
+namespace password_manager_metrics_util {
+
+// Contains a monitored domain name and all the group IDs which contain
+// domain name.
+struct DomainGroupsPair {
+  const char* domain_name;

[vabr (Chromium), 2013/09/11 17:31:24]

nit: const char* const
(Maybe that's what Ilya meant, but swapped char and const.)

[jdomingos, 2013/09/11 19:15:28]

Done.

+  const int group_ids[kGroupsPerDomain];
+};
+
+static unsigned int random_group_id = kGroupsPerDomain;

[vabr (Chromium), 2013/09/11 17:31:24]

Please prepend "g_" to the variable's name, as the style guide suggests.
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Variab...

Also, please put it into an anonymous namespace. I think you can then drop
"static", it will not be accessible from outside.

[jdomingos, 2013/09/11 19:15:28]

Done.

+
+// Generate an id in range [0, |kGroupsPerDomain|).
+// If the |random_group_id| is equal to its initial value (|kGroupsPerDomain|),
+// the value of |random_id| is not changed.
+void generateRandomId() {
+  // For each session, the user uses only one group for each website.
+  if (random_group_id == kGroupsPerDomain)
+    random_group_id = base::RandGenerator(kGroupsPerDomain);
+}
+
+// Only used in the IsDomainNameMonitoredTest.

[vabr (Chromium), 2013/09/11 17:31:24]

Please remove this comment. It's duplicated, and should be replaced by the
function's name suffix (ForTesting) anyway.

[jdomingos, 2013/09/11 19:15:28]

Done.

+void setRandomId(unsigned int value) {
+  random_group_id = value;
+}
+
+std::string MonitoredDomainGroup(const std::string& url_host) {
+  // This array contains each monitored websites together with all id of

[vabr (Chromium), 2013/09/11 17:31:24]

nit: id -> ids

[jdomingos, 2013/09/11 19:15:28]

Done.

+  // groups which contain the website. Each website appears |kGroupsPerDomain|
+  // times and every |group_ids| are different. For more information about the

[vabr (Chromium), 2013/09/11 17:31:24]

nit: "every |group_ids| are different" -> "every ID group is different"

[jdomingos, 2013/09/11 19:15:28]

Done.

+  // the algorithm used see http://goo.gl/vUuFd5.
+  static const DomainGroupsPair kDomainMapping[] = {
+      {"google.com", {1, 2, 3, 4, 5, 6, 7, 8, 9, 10}},
+      {"yahoo.com", {1, 2, 3, 4, 5, 11, 12, 13, 14, 15}},
+      {"baidu.com", {1, 2, 3, 4, 6, 7, 11, 12, 16, 17}},
+      {"wikipedia.org", {1, 2, 3, 4, 5, 6, 11, 12, 16, 18}},
+      {"linkedin.com", {1, 6, 8, 11, 13, 14, 15, 16, 17, 19}},
+      {"twitter.com", {5, 6, 7, 8, 9, 11, 13, 17, 19, 20}},
+      {"live.com", {7, 8, 9, 10, 13, 14, 16, 17, 18, 20}},
+      {"amazon.com", {2, 5, 9, 10, 12, 14, 15, 18, 19, 20}},
+      {"ebay.com", {3, 7, 9, 10, 14, 15, 17, 18, 19, 20}},
+      {"tumblr.com", {4, 8, 10, 12, 13, 15, 16, 18, 19, 20}},
+  };
+  const size_t kDomainMappingLength = arraysize(kDomainMapping);
+
+  generateRandomId();
+
+  GURL url(url_host);
+  for (size_t i = 0; i < kDomainMappingLength; ++i) {
+    std::string domain = kDomainMapping[i].domain_name;
+    if (url.DomainIs(domain.c_str())) {
+      return "group_" + base::IntToString(
+             kDomainMapping[i].group_ids[random_group_id]);
+    }
+  }
+  return std::string();
+}
+
+void LogUMAHistogramEnumeration(const std::string& name,
+                                int sample,
+                                int boundary_value) {
+  DCHECK_LT(sample, boundary_value);
+
+  // Note: This leaks memory, which is expected behavior.
+  base::HistogramBase* histogram =
+      base::LinearHistogram::FactoryGet(
+          name,
+          1,
+          boundary_value,
+          boundary_value + 1,
+          base::HistogramBase::kUmaTargetedHistogramFlag);
+  histogram->Add(sample);
+}
+
+void LogUMAHistogramTimes(const std::string& name,

[vabr (Chromium), 2013/09/11 17:31:24]

Do you still need this function? If not, please remove it.

[jdomingos, 2013/09/11 19:15:28]

Done.

+                          const base::TimeDelta& duration) {
+  // Note: This leaks memory, which is expected behavior.
+  base::HistogramBase* histogram =
+      base::Histogram::FactoryTimeGet(
+          name,
+          base::TimeDelta::FromMilliseconds(1),
+          base::TimeDelta::FromSeconds(10),
+          50,
+          base::HistogramBase::kUmaTargetedHistogramFlag);
+  histogram->AddTime(duration);
+}
+
+void LogUMAHistogramCounts(const std::string& name, int sample) {
+  // Note: This leaks memory, which is expected behavior.
+  base::HistogramBase* histogram =
+      base::Histogram::FactoryGet(
+          name,
+          1,
+          1000000,
+          kGroupNumber,
+          base::HistogramBase::kUmaTargetedHistogramFlag);
+  histogram->Add(sample);
+}
+
+void LogUMAHistogramBoolean(const std::string& name, bool sample) {
+  // Note: This leaks memory, which is expected behavior.
+  base::HistogramBase* histogram =
+      base::BooleanHistogram::FactoryGet(
+          name,
+          base::Histogram::kNoFlags);
+          histogram->AddBoolean(sample);
+}
+
+}  // namespace password_manager_metrics_util