Added of new UMA signals in order to be able to discover early if the "save password" feature gets …

chrome/browser/password_manager/password_manager_delegate_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/password_manager/password_manager_delegate_impl.h"
 
 #include "base/memory/singleton.h"
 #include "base/metrics/histogram.h"
 #include "base/strings/utf_string_conversions.h"
+#include "base/test/perftimer.h"
 #include "chrome/browser/infobars/confirm_infobar_delegate.h"
 #include "chrome/browser/infobars/infobar_service.h"
 #include "chrome/browser/password_manager/password_form_manager.h"
 #include "chrome/browser/password_manager/password_manager.h"
+#include "chrome/browser/password_manager/password_manager_metrics_util.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/sync/one_click_signin_helper.h"
 #include "components/autofill/content/browser/autofill_driver_impl.h"
 #include "components/autofill/core/browser/autofill_manager.h"
 #include "components/autofill/core/common/autofill_messages.h"
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/password_form.h"
 #include "content/public/common/ssl_status.h"
@@ skipping 43 matching lines @@
 
   virtual InfoBarAutomationType GetInfoBarAutomationType() const OVERRIDE;
 
   // The PasswordFormManager managing the form we're asking the user about,
   // and should update as per her decision.
   scoped_ptr<PasswordFormManager> form_to_save_;
 
   // Used to track the results we get from the info bar.
   ResponseType infobar_response_;
 
+  // Save password prompt lifetime needed for a UMA signal.
+  PerfTimer timer_;
+
+  // The |domain_name_| contained the current domain name prefixed with an
+  // underscore when we are on a website for which we monitor
+  // the save password prompt behaviour. Most of the time
+  // it is empty.

[Ilya Sherman, 2013/08/30 22:34:42]

nit: I find this comment rather hard to parse.  One possible rephrasing: "The
domain name corresponding to |form_to_save_| if the form is on a monitored
domain.  Otherwise, an empty string."  (See also my comment below about dropping
the underscore prefix.)

[jdomingos, 2013/09/02 09:58:45]

Done.

+  std::string domain_name_;

[Ilya Sherman, 2013/08/30 22:34:42]

nit: Perhaps rename this to |monitored_domain_name_|?

[jdomingos, 2013/09/02 09:58:45]

Done.

+
   DISALLOW_COPY_AND_ASSIGN(SavePasswordInfoBarDelegate);
 };
 
 // static
 void SavePasswordInfoBarDelegate::Create(content::WebContents* web_contents,
                                          PasswordFormManager* form_to_save) {
 #if defined(ENABLE_ONE_CLICK_SIGNIN)
   // Don't show the password manager infobar if this form is for a google
   // account and we are going to show the one-click signin infobar.
   GURL realm(form_to_save->realm());
@@ skipping 12 matching lines @@
   infobar_service->AddInfoBar(scoped_ptr<InfoBarDelegate>(
       new SavePasswordInfoBarDelegate(infobar_service, form_to_save)));
 }
 
 SavePasswordInfoBarDelegate::SavePasswordInfoBarDelegate(
     InfoBarService* infobar_service,
     PasswordFormManager* form_to_save)
     : ConfirmInfoBarDelegate(infobar_service),
       form_to_save_(form_to_save),
       infobar_response_(NO_RESPONSE) {
+  domain_name_ = password_manager_metrics_util::IsDomainNameMonitored(
+      form_to_save->realm());
+  if (domain_name_.size()) {

[Ilya Sherman, 2013/08/30 22:34:42]

nit: if (!domain_name_.empty())

[jdomingos, 2013/09/02 09:58:45]

Done.

+    domain_name_.insert(0, "_");

[Ilya Sherman, 2013/08/30 22:34:42]

Since all of the histogram logging code in this file now only logs data for
non-empty domain names, IMO it would be cleaner to include the underscore in the
histogram names rather than prepending it to the domain_name_.

[jdomingos, 2013/09/02 09:58:45]

Done.

+    password_manager_metrics_util::LogUMAHistogramCount(
+        "PasswordManager.InfobarDisplayed" + domain_name_, 1);
+  }
 }
 
 SavePasswordInfoBarDelegate::~SavePasswordInfoBarDelegate() {
+
   UMA_HISTOGRAM_ENUMERATION("PasswordManager.InfoBarResponse",
                             infobar_response_, NUM_RESPONSE_TYPES);
+  if (domain_name_.size()) {

[Ilya Sherman, 2013/08/30 22:34:42]

nit: if (!domain_name_.empty())

[jdomingos, 2013/09/02 09:58:45]

Done.

+    password_manager_metrics_util::LogUMAHistogramTimes(
+        "PasswordManager.InfoBarResponse" + domain_name_, timer_.Elapsed());
+  }
 }
 
 int SavePasswordInfoBarDelegate::GetIconID() const {
   return IDR_INFOBAR_SAVE_PASSWORD;
 }
 
 InfoBarDelegate::Type SavePasswordInfoBarDelegate::GetInfoBarType() const {
   return PAGE_ACTION_TYPE;
 }
 
@@ skipping 59 matching lines @@
 bool PasswordManagerDelegateImpl::DidLastPageLoadEncounterSSLErrors() {
   content::NavigationEntry* entry =
       web_contents_->GetController().GetActiveEntry();
   if (!entry) {
     NOTREACHED();
     return false;
   }
 
   return net::IsCertStatusError(entry->GetSSL().cert_status);
 }