tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 7abdedd66b1459fda7be7b22025ce4165ce7c553..eb1ff4a0628efd82452ef62e22ba06ec627f1f98 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -10235,6 +10235,20 @@ other types of suffix sets.
   </summary>
 </histogram>
 
+<histogram name="PasswordManager.Enabled" enum="BooleanEnabled">
+  <summary>Indicates if the password manager is enabled.</summary>

[Ilya Sherman, 2013/08/29 06:46:44]

Please specify when this is logged.

[jdomingos, 2013/08/30 21:09:20]

Done.

+</histogram>
+
+<histogram name="PasswordManager.InfobarDisplayed">
+  <summary>
+    A boolean that indicates whether the save password prompt is displayed.

[Ilya Sherman, 2013/08/29 06:46:44]

This is a confusing description, as the histogram can never emit any "false"
values, only "true" ones.

[jdomingos, 2013/08/30 21:09:20]

Done.

+  </summary>
+</histogram>
+
+<histogram name="PasswordManager.InfobarLifetime">

[Ilya Sherman, 2013/08/29 06:46:44]

nit: Please specify the units.

+  <summary>Indicates the lifetime of the save password prompt.</summary>

[Ilya Sherman, 2013/08/29 06:46:44]

nit: Please reword this to be a little bit clearer; for example, something along
the lines of: "The time elapsed between when a "Save password?" infobar was
shown and when it was hidden.  The infobar can be hidden either as a result of
user interaction with the infobar, or automatically when the page is navigated
or the tab is closed."

[jdomingos, 2013/08/30 21:09:20]

Done.

+</histogram>
+
 <histogram name="PasswordManager.OtherPossibleUsernamesUsage"
     enum="OtherPossibleUsernamesUsage">
   <summary>
@@ -10243,6 +10257,13 @@ other types of suffix sets.
   </summary>
 </histogram>
 
+<histogram name="PasswordManager.PreviousPasswordSavedRecently">
+  <summary>
+    A boolean which indicates if the current user saved a password for the same
+    login for the current website recently.
+  </summary>
+</histogram>

[Ilya Sherman, 2013/08/29 06:46:44]

Hmm, I don't see this histogram being logged in the C++ code...

[jdomingos, 2013/08/30 21:09:20]

Done.

+
 <histogram name="PasswordManager.ProvisionalSaveFailure"
     enum="ProvisionalSaveFailure">
   <summary>
@@ -25317,6 +25338,21 @@ other types of suffix sets.
   <affected-histogram name="Renderer4.BeginToFinishDoc"/>
 </fieldtrial>
 
+<fieldtrial name="PasswordManagerMonitor">
+  <group name="google.com" label="google"/>
+  <group name="yahoo.com" label="yahoo"/>
+  <group name="baidu.com" label="baidu"/>
+  <group name="wikipedia.org" label="wikipedia"/>
+  <group name="linkedin.com" label="linkedin"/>
+  <group name="live.com" label="live"/>
+  <group name="twitter.com" label="twitter"/>
+  <group name="amazon.com" label="amazon"/>

[Ilya Sherman, 2013/08/29 06:46:44]

Looking at the code, it seems like you should also have a group with an empty
name.

[jdomingos, 2013/08/30 21:09:20]

Only the PasswordManager.ProvisionalSaveFailure needs an empty group name. Are
you sure that I should add it ?

[Ilya Sherman, 2013/08/30 22:34:42]

If you don't include the empty group name, then I'm pretty sure the histogram
will not appear on the dashboard with just the base name, i.e. you won't see the
data for the PasswordManager.ProvisionalSaveFailure not broken down by domain
name.

+  <affected-histogram name="PasswordManager.InfobarDisplayed"/>
+  <affected-histogram name="PasswordManager.InfobarLifetime"/>
+  <affected-histogram name="PasswordManager.PreviousPasswordSavedRecently"/>
+  <affected-histogram name="PasswordManager.ProvisionalSaveFailure"/>
+</fieldtrial>
+
 <fieldtrial name="PpapiPluginName">
   <group name="libpepflashplayer.so" label="Flash player on Linux or Cros"/>
   <group name="libwidevinecdmadapter.so" label="Widevine CDM on Linux or Cros"/>