Added of new UMA signals in order to be able to discover early if the "save password" feature gets …

chrome/browser/password_manager/password_manager_util.h

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_MANAGER_UTIL_H_
+#define CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_MANAGER_UTIL_H_

[Ilya Sherman, 2013/08/29 06:42:21]

How about password_manager_metrics_util.h?  General "util" files tend to devolve
into unfocused dumping grounds.

[jdomingos, 2013/08/30 21:09:20]

Done.

+
+#include <string>
+
+#include "base/basictypes.h"
+
+namespace password_manager_util {
+
+// Check whether the |url_host| is monitored or not. If yes, we put the

[Ilya Sherman, 2013/08/29 06:42:21]

nit: "monitored or not" -> "monitored for metrics"

[jdomingos, 2013/08/30 21:09:20]

Done.

+// domain name into |domain_name|

[Ilya Sherman, 2013/08/29 06:42:21]

nit: End the sentence with a period.

[jdomingos, 2013/08/30 21:09:20]

Done.

+bool IsDomainNameMonitored(const std::string& url_host,
+                           std::string* domain_name);

[Ilya Sherman, 2013/08/29 06:42:21]

Seems like you might want to annotate this with WARN_UNUSED_RESULT.  If not, you
might as well just drop the boolean return value, and simply return the
domain_name, or an empty string if the domain name isn't one we're explicitly
monitoring.

[jdomingos, 2013/08/30 21:09:20]

Done.

+
+}  // namespace password_manager_util
+
+#endif  // CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_MANAGER_UTIL_H_