Added of new UMA signals in order to be able to discover early if the "save password" feature gets …

chrome/browser/password_manager/password_manager_util.cc

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/password_manager/password_manager_util.h"
+
+#include "base/strings/string_util.h"
+
+namespace password_manager_util {
+
+bool IsDomainNameMonitored(const std::string& url_host,
+                           std::string* domain_name) {
+  const char *kMonitoredDomainName[] = {

[Ilya Sherman, 2013/08/29 06:42:21]

nit: "char*" (swap the position of the asterisk and the space)

[jdomingos, 2013/08/30 21:09:20]

Done.

+    "google.com",
+    "yahoo.com",
+    "baidu.com",
+    "wikipedia.org",
+    "linkedin.com",
+    "twitter.com",
+    "live.com",
+    "amazon.com",
+  };

[Ilya Sherman, 2013/08/29 06:42:21]

Oof, this seems really questionable from a privacy perspective.  *Please* make
sure to check with the privacy team whether it's ok to record user visits to
specific websites like this.

[vabr (Chromium), 2013/08/29 08:15:13]

I can confirm that somebody other than me will be reviewing this on the Privacy
team.
It is being tracked for M31 reviews under http://crbug.com/268980 (I Cc-ed Ilya
for access).

[Ilya Sherman, 2013/08/29 22:42:43]

I'm not comfortable approving this change prior to it being reviewed by the
privacy team.

+  const size_t kMonitoredDomainNameLength = arraysize(kMonitoredDomainName);
+
+  domain_name->clear();
+
+  for (std::string::size_type i = 0; i < kMonitoredDomainNameLength; ++i) {

[Ilya Sherman, 2013/08/29 06:42:21]

nit: You can just use size_t rather than std::string::size_type

[jdomingos, 2013/08/30 21:09:20]

Done.

+    size_t point_position =
+        url_host.size() - strlen(kMonitoredDomainName[i]) - 1;
+
+    if (url_host == kMonitoredDomainName[i] ||
+        (EndsWith(url_host, kMonitoredDomainName[i], true) &&
+         url_host[point_position] == '.')) {

[Ilya Sherman, 2013/08/29 06:42:21]

Please use the GURL and url_parse::Parsed classes for parsing URLs.

[jdomingos, 2013/08/30 21:09:20]

I don't understand what you want me to do here.
Could you please add additional details please ?

+      *domain_name = kMonitoredDomainName[i];
+      return true;
+    }
+  }
+  return false;
+}
+
+}  // namespace password_manager_util