Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Side by Side Diff: chrome/browser/password_manager/password_manager.h

Issue 23140005: Added of new UMA signals in order to be able to discover early if the "save password" feature gets … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review 3 Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_MANAGER_H_ 5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_MANAGER_H_
6 #define CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_MANAGER_H_ 6 #define CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_MANAGER_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 EMPTY_PASSWORD, 107 EMPTY_PASSWORD,
108 NO_MATCHING_FORM, 108 NO_MATCHING_FORM,
109 MATCHING_NOT_COMPLETE, 109 MATCHING_NOT_COMPLETE,
110 FORM_BLACKLISTED, 110 FORM_BLACKLISTED,
111 INVALID_FORM, 111 INVALID_FORM,
112 AUTOCOMPLETE_OFF, 112 AUTOCOMPLETE_OFF,
113 MAX_FAILURE_VALUE 113 MAX_FAILURE_VALUE
114 }; 114 };
115 115
116 // Log failure for UMA 116 // Log failure for UMA
117 void RecordFailure(ProvisionalSaveFailure failure); 117 void RecordFailure(ProvisionalSaveFailure failure,
118 const std::string& url_host);
118 119
119 // Possibly set up FieldTrial for testing other possible usernames. This only 120 // Possibly set up FieldTrial for testing other possible usernames. This only
120 // happens if there are other_possible_usernames to be shown and the 121 // happens if there are other_possible_usernames to be shown and the
121 // experiment hasn't already been initialized. We setup the experiment at 122 // experiment hasn't already been initialized. We setup the experiment at
122 // such a late time because this experiment will only affect a small number 123 // such a late time because this experiment will only affect a small number
123 // of users so we want to include a larger fraction of these users than the 124 // of users so we want to include a larger fraction of these users than the
124 // normal 10%. 125 // normal 10%.
125 void PossiblyInitializeUsernamesExperiment( 126 void PossiblyInitializeUsernamesExperiment(
126 const content::PasswordFormMap& matches) const; 127 const content::PasswordFormMap& matches) const;
127 128
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
169 // notification in const member functions. 170 // notification in const member functions.
170 mutable ObserverList<LoginModelObserver> observers_; 171 mutable ObserverList<LoginModelObserver> observers_;
171 172
172 // Callbacks to be notified when a password form has been submitted. 173 // Callbacks to be notified when a password form has been submitted.
173 std::vector<PasswordSubmittedCallback> submission_callbacks_; 174 std::vector<PasswordSubmittedCallback> submission_callbacks_;
174 175
175 DISALLOW_COPY_AND_ASSIGN(PasswordManager); 176 DISALLOW_COPY_AND_ASSIGN(PasswordManager);
176 }; 177 };
177 178
178 #endif // CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_MANAGER_H_ 179 #endif // CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698