Added of new UMA signals in order to be able to discover early if the "save password" feature gets …

chrome/browser/password_manager/password_manager_util.h

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_MANAGER_UTIL_H_
+#define CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_MANAGER_UTIL_H_
+
+#include <string>
+
+#include "base/basictypes.h"
+
+namespace PasswordManagerUtil {

[Garrett Casto, 2013/08/28 01:09:17]

Namespace are lowercase
(http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Namespace_Names)

+
+const std::string kMonitoredDomainName[] = {

[Garrett Casto, 2013/08/28 01:09:17]

Use char* instead of std::string
(http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Static_and_Glo...).
This should probably also be in the .cc file as I'm assuming you always want
callers to access this through IsDomainNameMonitored.

+  "google.com",
+  "yahoo.com",
+  "baidu.com",
+  "wikipedia.org",
+  "linkedin.com",
+  "twitter.com",
+  "live.com",
+  "amazon.com",
+};
+
+const size_t kMonitoredDomainNameLength = arraysize(kMonitoredDomainName);
+
+// Check wether the |url_host| is monitored or not. If yes, we put the

[Garrett Casto, 2013/08/28 01:09:17]

"whether"

+// domain name into |domain_name|
+bool IsDomainNameMonitored(const std::string& url_host,

[Garrett Casto, 2013/08/28 01:09:17]

Should probably have some basic unit testing for this.

+                           std::string& domain_name);

[Garrett Casto, 2013/08/28 01:09:17]

It is very rare for functions in Chrome to use a reference for a mutable
parameter
(http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Reference_Argu...).
Use a pointer instead.

+
+}  // namespace PasswordManagerUtil
+
+#endif  // CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_MANAGER_UTIL_H_