Added of new UMA signals in order to be able to discover early if the "save password" feature gets …

chrome/browser/password_manager/password_manager_metrics_util_unittest.cc

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/password_manager/password_manager_metrics_util.h"
+
+#include <iterator>
+#include <map>
+
+#include "base/basictypes.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace {
+
+bool IsMonitored(const char* url_host) {
+  return password_manager_metrics_util::MonitoredDomainGroupId(url_host) > 0;
+}
+
+}  // namespace
+
+TEST(PasswordManagerTest, MonitoredDomainGroupAssigmentTest) {
+  const char* const kMonitoredWebsites[] = {
+      "https://www.google.com",
+      "https://www.yahoo.com",
+      "https://www.baidu.com",
+      "https://www.wikipedia.org",
+      "https://www.linkedin.com",
+      "https://www.twitter.com",
+      "https://www.live.com",
+      "https://www.amazon.com",
+      "https://www.ebay.com",
+      "https://www.tumblr.com",
+  };
+  const size_t kMonitoredWebsitesLength = arraysize(kMonitoredWebsites);
+
+  // The |groups| map contains the group id and the number of times
+  // it get assigned.
+  std::map<size_t, size_t> groups;
+
+  // Provide all possible values of the group id parameter for each monitored
+  // website.
+  for (size_t i = 0; i < kMonitoredWebsitesLength; ++i) {
+    for (size_t j = 0; j < password_manager_metrics_util::kGroupsPerDomain;
+         ++j) {
+      password_manager_metrics_util::SetRandomIdForTesting(j);
+      ++groups[password_manager_metrics_util::MonitoredDomainGroupId(
+            kMonitoredWebsites[i])];
+    }
+  }
+
+  // Check if all groups get assigned the same number of times.
+  size_t number_of_assigment = groups.begin()->second;
+  for (std::map<size_t, size_t>::iterator it = groups.begin();
+       it != groups.end(); ++it) {
+    EXPECT_EQ(it->second, number_of_assigment) << " group id = " << it->first;
+  }
+}
+
+TEST(PasswordManagerTest, MonitoredDomainGroupTest) {
+  size_t group_id;

[Ilya Sherman, 2013/09/14 03:33:25]

This type is no longer correct -- it should be a bool.  Better yet, though,
would be to simply remove the variable, and write expectations like

EXPECT_TRUE(IsMonitored("https://www.linkedin.com"));

+
+  group_id = IsMonitored("https://www.linkedin.com");
+  EXPECT_LT(0u, group_id);

[Ilya Sherman, 2013/09/14 03:33:25]

Note that EXPECT_LT doesn't really make sense anymore with a boolean return
value from IsMonitored.

+  group_id = IsMonitored("https://www.amazon.com");
+  EXPECT_LT(0u, group_id);
+  group_id = IsMonitored("https://www.facebook.com");
+  EXPECT_EQ(0u, group_id);
+  group_id = IsMonitored("http://wikipedia.org");
+  EXPECT_LT(0u, group_id);
+  group_id = IsMonitored("http://thisisnotwikipedia.org");
+  EXPECT_EQ(0u, group_id);
+}