tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index f1069c1508322ab1bc870f83cacf6e518c032268..9135799091db64ea106c2611e6194c9c9f7086c0 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -9473,6 +9473,19 @@ other types of suffix sets.
   </summary>
 </histogram>
 
+<histogram name="PasswordManager.InfobarDislayedTooShortly">

[vabr (Chromium), 2013/08/14 14:39:58]

I saw a couple of Boolean* enum types in
http://chromegw/viewvc/chrome-internal/trunk/tools/histograms/histograms.xml?....
Maybe we could use them or create a similar one in that fashion?

I'm not sure what is the guidance here, maybe Garrett knows?

[Garrett Casto, 2013/08/14 23:02:47]

It looks like people seem to just use enum="BooleanSuccess", but not my area of
expertise.

+  <summary>
+    A boolean that indicates if the info bar has been displayed too shortly in
+    term of time.

[vabr (Chromium), 2013/08/14 14:39:58]

nit: "in term of time" could be probably left out; or at least please substitute
term->terms.

+  </summary>
+</histogram>
+
+<histogram name="PasswordManager.InfobarDisplayed">
+  <summary>
+    A boolean that indicates whether the save password info bar is displayed.
+  </summary>
+</histogram>
+
 <histogram name="PasswordManager.OtherPossibleUsernamesUsage"
     enum="OtherPossibleUsernamesUsage">
   <summary>
@@ -9481,6 +9494,20 @@ other types of suffix sets.
   </summary>
 </histogram>
 
+<histogram name="PasswordManager.PotentialInfoBarErrorReasons"
+    enum="PotentialInfoBarErrorReasons">
+  <summary>
+    List of the reasons to not display the save password info bar.

[vabr (Chromium), 2013/08/14 14:39:58]

This is not a list, right? Is it rather "an enumeration of possible reasons..."?

+  </summary>
+</histogram>
+
+<histogram name="PasswordManager.PreviousPasswordSavedRecently">
+  <summary>
+    A boolean that indicates if the current user saved his password for in the

[vabr (Chromium), 2013/08/14 14:39:58]

"for in" -> for
"his password" -> "a password for the same login"

+    current website recently.
+  </summary>
+</histogram>
+
 <histogram name="PasswordManager.TimesGeneratedPasswordUsed">
   <summary>
     The number of times each generated password has been used to log in.
@@ -20363,6 +20390,22 @@ other types of suffix sets.
   <int value="5" label="5"/>
 </enum>
 
+<enum name="PotentialInfoBarErrorReasons" type="int">

[vabr (Chromium), 2013/08/14 14:39:58]

Don't forget to update this definition once you change the corresponding enum in
the C++ code.

+  <int value="0" label="SPDY_PROXY"/>
+  <int value="1" label="SAVE_PASSWORD_DISABLE"/>
+  <int value="2" label="EMPTY_PASSWORD"/>
+  <int value="3" label="FIRST_PAGE_NOT_LOADED"/>
+  <int value="4" label="MATCHING_ONGOING"/>
+  <int value="5" label="NEVER_REMEMBER"/>
+  <int value="6" label="INVALID_FORM"/>
+  <int value="7" label="PASSWORD_GENERATED_OR_AUTOCOMPLETED"/>
+  <int value="8" label="CANNOT_GET_THE_PROVIOSIONAL_PASSWORD"/>
+  <int value="9" label="FORM_REAPPEARED"/>
+  <int value="10" label="LOGIN_ALREADY_KNEW"/>
+  <int value="11" label="PASSWORD_GENERATED"/>
+  <int value="12" label="ORIGIN_MATCHING_OF_PUBLIC_SUFFIX"/>
+</enum>
+
 <enum name="PowerBrightnessAdjust" type="int">
   <int value="0" label="Brightness Down"/>
   <int value="1" label="Brightness Up"/>
@@ -23971,6 +24014,15 @@ other types of suffix sets.
   <affected-histogram name="Renderer4.BeginToFinishDoc"/>
 </fieldtrial>
 
+<fieldtrial name="PasswordManagerMonitor">
+  <group name="twitter" label="twitter"/>

[vabr (Chromium), 2013/08/14 14:39:58]

We should make up our mind about which hosts to include in the monitoring.
Can you take the first 10 of Patrick Nepper's list?

+  <group name="youtube" label="youtube"/>
+  <affected-histogram name="PasswordManager.InfobarDislayedTooShortly"/>
+  <affected-histogram name="PasswordManager.InfobarDisplayed"/>
+  <affected-histogram name="PasswordManager.PotentialInfoBarErrorReasons"/>
+  <affected-histogram name="PasswordManager.PreviousPasswordSavedRecently"/>
+</fieldtrial>
+
 <fieldtrial name="PpapiPluginName">
   <group name="libpepflashplayer.so" label="Flash player on Linux or Cros"/>
   <group name="libwidevinecdmadapter.so" label="Widevine CDM on Linux or Cros"/>