Added of new UMA signals in order to be able to discover early if the "save password" feature gets …

chrome/browser/password_manager/password_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_MANAGER_H_
 #define CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_MANAGER_H_
 
 #include <vector>
 
 #include "base/memory/scoped_ptr.h"
@@ skipping 17 matching lines @@
 }
 
 // Per-tab password manager. Handles creation and management of UI elements,
 // receiving password form data from the renderer and managing the password
 // database through the PasswordStore. The PasswordManager is a LoginModel
 // for purposes of supporting HTTP authentication dialogs.
 class PasswordManager : public LoginModel,
                         public content::WebContentsObserver,
                         public content::WebContentsUserData<PasswordManager> {
  public:
+  enum PotentialInfoBarErrorReasons {
+    SPDY_PROXY,
+    SAVE_PASSWORD_DISABLE,

[vabr (Chromium), 2013/08/14 14:39:58]

nit: DISABLE->DISABLED ?

+    EMPTY_PASSWORD,
+    FIRST_PAGE_NOT_LOADED,
+    MATCHING_ONGOING,
+    NEVER_REMEMBER,
+    INVALID_FORM,
+    PASSWORD_GENERATED_OR_AUTOCOMPLETED,
+    CANNOT_GET_THE_PROVIOSIONAL_PASSWORD,

[vabr (Chromium), 2013/08/14 14:39:58]

typo: PROVIOSIONAL

+    FORM_REAPPEARED,
+    LOGIN_ALREADY_KNEW,

[vabr (Chromium), 2013/08/14 14:39:58]

nit: KNEW->KNOWN ?

+    PASSWORD_GENERATED,

[vabr (Chromium), 2013/08/14 14:39:58]

How does this differ from PASSWORD_GENERATED_OR_AUTOCOMPLETED?

+    ORIGIN_MATCHING_OF_PUBLIC_SUFFIX,

[vabr (Chromium), 2013/08/14 14:39:58]

nit: leave out "OF" ?

+    NUM_ERROR_TYPES

[vabr (Chromium), 2013/08/14 14:39:58]

Here I am not sure about the C++ standard -- are we guaranteed that the enum
values are numbered from 0 up by +1 increments?
If yes, then this is fine.
Otherwise we need to assign values explicitly.

[Garrett Casto, 2013/08/14 23:02:47]

Yep.

+  };
+
   static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry);
 
   static void CreateForWebContentsAndDelegate(
       content::WebContents* contents,
       PasswordManagerDelegate* delegate);
   virtual ~PasswordManager();
 
   // Is saving new data for password autofill enabled for the current profile?
   // For example, saving new data is disabled in Incognito mode, whereas filling
   // data is not.
@@ skipping 91 matching lines @@
   BooleanPrefMember password_manager_enabled_;
 
   // Observers to be notified of LoginModel events.  This is mutable to allow
   // notification in const member functions.
   mutable ObserverList<LoginModelObserver> observers_;
 
   DISALLOW_COPY_AND_ASSIGN(PasswordManager);
 };
 
 #endif  // CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_MANAGER_H_