tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 30cd03f55469e4aae9bbbb9efe85a856131ac662..8503cf724bf11d713c3057034af1280ad2a3dc49 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -20638,6 +20638,47 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="JSDialogs.CountOfCharactersKarmaHigher">

[Alexei Svitkine (slow), 2016/09/07 22:13:12]

Nit: For all of these add a units= attr

[Avi (use Gerrit), 2016/09/07 22:32:10]

Done.

+  <owner>avi@chromium.org</owner>
+  <summary>
+    The count of the number of characters in JavaScript dialog messages shown by
+    a page that has a site engagement score of higher than 5.
+  </summary>
+</histogram>
+
+<histogram name="JSDialogs.CountOfCharactersKarmaLessThanOne">

[Alexei Svitkine (slow), 2016/09/07 22:13:12]

Nit: Just a naming suggestion. I find the current naming scheme a bit hard to
read.

Couple of suggestions:
  - Maybe CharacterCount instead of CountOfCharacters?
  - Maybe add an intermediate . for grouping?

So it could be JSDialogs.CharacterCount.KarmaLessThanOne.

You can use the histogram_suffixes construct in histograms.xml to define all the
suffixes so you don't need to duplicate the histogram definitions. See the
example in the comment at the top of histograms.xml on how to do this.

[Avi (use Gerrit), 2016/09/07 22:32:11]

Done.

+  <owner>avi@chromium.org</owner>
+  <summary>
+    The count of the number of characters in JavaScript dialog messages shown by
+    a page that has a site engagement score of less than 1.
+  </summary>
+</histogram>
+
+<histogram name="JSDialogs.CountOfCharactersKarmaNone">
+  <owner>avi@chromium.org</owner>
+  <summary>
+    The count of the number of characters in JavaScript dialog messages shown by
+    a page that has a site engagement score of 0.
+  </summary>
+</histogram>
+
+<histogram name="JSDialogs.CountOfCharactersKarmaOneToFive">
+  <owner>avi@chromium.org</owner>
+  <summary>
+    The count of the number of characters in JavaScript dialog messages shown by
+    a page that has a site engagement score between 1 and less than 5.
+  </summary>
+</histogram>
+
+<histogram name="JSDialogs.CountOfCharactersUserSuppressed">
+  <owner>avi@chromium.org</owner>
+  <summary>
+    The count of the number of characters in JavaScript dialog messages that
+    were suppressed by the user. Compare with
+    JSDialogs.CountOfJSDialogMessageCharacters.
+  </summary>
+</histogram>
+
 <histogram name="JSDialogs.CountOfJSDialogMessageCharacters">
   <owner>avi@chromium.org</owner>
   <summary>
@@ -20712,6 +20753,18 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="JSDialogs.SiteKarmaOfBeforeUnload">
+  <owner>avi@chromium.org</owner>
+  <summary>
+    The site engagement values of sites showing onbeforeunload dialogs.
+  </summary>
+</histogram>
+
+<histogram name="JSDialogs.SiteKarmaOfDialogs">
+  <owner>avi@chromium.org</owner>
+  <summary>The site engagement values of sites showing dialogs.</summary>
+</histogram>
+
 <histogram name="Keyboard.KeystrokeDeltas" units="ms">
   <obsolete>
     Deprecated 07/2016 in crbug.com/631204 with KeyboardUmaEventFilter removal.