tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 30cd03f55469e4aae9bbbb9efe85a856131ac662..9ab151d480b584da7305fafc6aa632ed7afa9677 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -20638,7 +20638,24 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
-<histogram name="JSDialogs.CountOfJSDialogMessageCharacters">
+<histogram name="JSDialogs.CharacterCount" units="characters">
+  <owner>avi@chromium.org</owner>
+  <summary>
+    The count of the number of characters in JavaScript dialog messages grouped
+    by site engagement score.
+  </summary>
+</histogram>
+
+<histogram name="JSDialogs.CharacterCountUserSuppressed" units="characters">

[Alexei Svitkine (slow), 2016/09/08 15:01:42]

Nit: How about CharacterCount.UserSuppressed?

[Avi (use Gerrit), 2016/09/08 15:21:38]

But UserSuppressed isn't a flavor of user engagement. Do we usually group that
kind of a count together with the others?

+  <owner>avi@chromium.org</owner>
+  <summary>
+    The count of the number of characters in JavaScript dialog messages that
+    were suppressed by the user. Compare with
+    JSDialogs.CountOfJSDialogMessageCharacters.

[Alexei Svitkine (slow), 2016/09/08 15:01:42]

JSDialogs.CharacterCount

[Avi (use Gerrit), 2016/09/08 15:21:38]

No, JSDialogs.CountOfJSDialogMessageCharacters is an existing UMA stat that has
been around for months with that name.

+  </summary>
+</histogram>
+
+<histogram name="JSDialogs.CountOfJSDialogMessageCharacters" units="characters">
   <owner>avi@chromium.org</owner>
   <summary>
     The count of the number of characters in JavaScript dialog messages.
@@ -20653,7 +20670,8 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
-<histogram name="JSDialogs.CountOfOnBeforeUnloadMessageCharacters">
+<histogram name="JSDialogs.CountOfOnBeforeUnloadMessageCharacters"
+    units="characters">
   <obsolete>
     Deprecated 2016-02.
   </obsolete>
@@ -20712,6 +20730,18 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="JSDialogs.SiteEngagementOfBeforeUnload" units="%">
+  <owner>avi@chromium.org</owner>
+  <summary>
+    The site engagement values of sites showing onbeforeunload dialogs.
+  </summary>
+</histogram>
+
+<histogram name="JSDialogs.SiteEngagementOfDialogs" units="%">
+  <owner>avi@chromium.org</owner>
+  <summary>The site engagement values of sites showing dialogs.</summary>

[Alexei Svitkine (slow), 2016/09/08 15:01:42]

Nit: Mention when this is logged. Once per JS dialog? Once per site?

[Avi (use Gerrit), 2016/09/08 15:21:38]

Done.

+</histogram>
+
 <histogram name="Keyboard.KeystrokeDeltas" units="ms">
   <obsolete>
     Deprecated 07/2016 in crbug.com/631204 with KeyboardUmaEventFilter removal.
@@ -100956,6 +100986,14 @@ To add a new entry, add it with any value and run test to compute valid value.
   <affected-histogram name="DNS.PrefetchResolution"/>
 </histogram_suffixes>
 
+<histogram_suffixes name="JSDialogs.EngagementList" separator=".">
+  <suffix name="EngagementNone" label="site engagement = 0"/>
+  <suffix name="EngagementLessThanOne" label="site engagement &lt; 1"/>
+  <suffix name="EngagementOneToFive" label="site engagement &gt;= 1, &lt; 5"/>
+  <suffix name="EngagementHigher" label="site engagement &gt;= 5"/>
+  <affected-histogram name="JSDialogs.CharacterCount"/>
+</histogram_suffixes>
+
 <histogram_suffixes name="LateBindingExperiment">
   <suffix name="disable_late_binding" label="socket late binding is disabled"/>
   <suffix name="enable_late_binding" label="socket late binding is enabled"/>