Issue 23139002: Merge 217139 "[Mac] Change to detach the web contents view when ..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23139002: Merge 217139 "[Mac] Change to detach the web contents view when ..." (Closed)

Created:
7 years, 4 months ago by jianli

Modified:
7 years, 4 months ago

Reviewers:
jianli

CC:
chromium-reviews, jennb, Dmitry Titov, dcheng

Base URL:
svn://svn.chromium.org/chrome/branches/1547/src/

Visibility:
Public.

Merge 217139 "[Mac] Change to detach the web contents view when ..." > [Mac] Change to detach the web contents view when the panel is not taller than the titlebar. > > We used to hide the web contents view in such case but it seems to trigger some bad effect occasionally. > > BUG=265932 > TEST=existing tests > R=ccameron@chromium.org, dimich@chromium.org > > Review URL: https://codereview.chromium.org/22629009 TBR=jianli@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217371

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -11 lines)			Patch
	M	chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.mm	View		1 chunk	+26 lines, -11 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r217371.