third_party/WebKit/Source/core/layout/ng/ng_fragment_base.cc - Issue 2313873002: Initial implementation of Collapsing Margins computational logic for LayoutNG

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_fragment_base.cc

Issue 2313873002: Initial implementation of Collapsing Margins computational logic for LayoutNG (Closed)

Patch Set: synced to the head Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/ng_fragment_base.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_fragment_base.cc b/third_party/WebKit/Source/core/layout/ng/ng_fragment_base.cc

index 0193580f4274530889d7a892239262b452502d32..14ea494007e6e1b52690d9505cef603ef5440143 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_fragment_base.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_fragment_base.cc

@@ -41,6 +41,11 @@ LayoutUnit NGFragmentBase::BlockOffset() const {

: physical_fragment_->LeftOffset();

}

+NGMarginStrut NGFragmentBase::MarginStrut() const {

+ // TODO(layout-ng): Change MarginStrut to support writing direction.

+ return physical_fragment_->MarginStrut();

DEFINE_TRACE(NGFragmentBase) {

visitor->trace(physical_fragment_);

}