MD History: Remove shadow root from <history-searched-label>

MD History: Remove shadow root from <history-searched-label>

The <history-searched-label> element directly modifies its own DOM
without using a template or styling. The <template> and corresponding
shadow root can be removed without affecting the functionality of the
element.

Removing these saves one shadow root and one div per <history-item>
element, which has a very minor performance impact while also
simplifying the element.

BUG=629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/5e1f45d8c5fff4a1e635616bace6ce4f6ec3aa78
Cr-Commit-Position: refs/heads/master@{#416603}

[tsergeant, 2016-09-06 00:07:42]

Description was changed from

==========
MD History: Remove shadow root from <history-searched-label>

The <history-searched-label> element directly modifies its own DOM
without using a template or styling. The <template> and corresponding
shadow root can be removed without affecting the functionality of the
element.

Removing these saves one shadow root and one div per <history-item>
element, which does not appear to have a measurable performance impact,
but does simplify the element in code and in the DOM tree.

BUG=629710
==========

to

==========
MD History: Remove shadow root from <history-searched-label>

The <history-searched-label> element directly modifies its own DOM
without using a template or styling. The <template> and corresponding
shadow root can be removed without affecting the functionality of the
element.

Removing these saves one shadow root and one div per <history-item>
element, which does not appear to have a measurable performance impact,
but does simplify the element in code and in the DOM tree.

BUG=629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-09-06 00:08:40]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 00:08:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2016-09-06 00:14:58]

Description was changed from

==========
MD History: Remove shadow root from <history-searched-label>

The <history-searched-label> element directly modifies its own DOM
without using a template or styling. The <template> and corresponding
shadow root can be removed without affecting the functionality of the
element.

Removing these saves one shadow root and one div per <history-item>
element, which does not appear to have a measurable performance impact,
but does simplify the element in code and in the DOM tree.

BUG=629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: Remove shadow root from <history-searched-label>

The <history-searched-label> element directly modifies its own DOM
without using a template or styling. The <template> and corresponding
shadow root can be removed without affecting the functionality of the
element.

Removing these saves one shadow root and one div per <history-item>
element, which has a very minor performance impact (1-2% off first
paint), while simplifying the element.

BUG=629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-09-06 00:16:19]

Description was changed from

==========
MD History: Remove shadow root from <history-searched-label>

The <history-searched-label> element directly modifies its own DOM
without using a template or styling. The <template> and corresponding
shadow root can be removed without affecting the functionality of the
element.

Removing these saves one shadow root and one div per <history-item>
element, which has a very minor performance impact (1-2% off first
paint), while simplifying the element.

BUG=629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: Remove shadow root from <history-searched-label>

The <history-searched-label> element directly modifies its own DOM
without using a template or styling. The <template> and corresponding
shadow root can be removed without affecting the functionality of the
element.

Removing these saves one shadow root and one div per <history-item>
element, which has a very minor performance impact while also
simplifying the element.

BUG=629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-09-06 00:16:35]

tsergeant@chromium.org changed reviewers:
+ calamity@chromium.org

[commit-bot: I haz the power, 2016-09-06 00:49:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 00:49:51]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tsergeant, 2016-09-06 01:26:02]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 01:26:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 02:16:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 02:16:22]

Dry run: This issue passed the CQ dry run.

[calamity, 2016-09-06 06:53:07]

lgtm

[tsergeant, 2016-09-06 07:39:45]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2016-09-06 07:39:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 07:43:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-06 07:45:01]

Description was changed from

==========
MD History: Remove shadow root from <history-searched-label>

The <history-searched-label> element directly modifies its own DOM
without using a template or styling. The <template> and corresponding
shadow root can be removed without affecting the functionality of the
element.

Removing these saves one shadow root and one div per <history-item>
element, which has a very minor performance impact while also
simplifying the element.

BUG=629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: Remove shadow root from <history-searched-label>

The <history-searched-label> element directly modifies its own DOM
without using a template or styling. The <template> and corresponding
shadow root can be removed without affecting the functionality of the
element.

Removing these saves one shadow root and one div per <history-item>
element, which has a very minor performance impact while also
simplifying the element.

BUG=629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/5e1f45d8c5fff4a1e635616bace6ce4f6ec3aa78
Cr-Commit-Position: refs/heads/master@{#416603}
==========

[commit-bot: I haz the power, 2016-09-06 07:45:03]

Patchset 2 (id:??) landed as
https://crrev.com/5e1f45d8c5fff4a1e635616bace6ce4f6ec3aa78
Cr-Commit-Position: refs/heads/master@{#416603}

[Dan Beam, 2016-09-06 15:54:32]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-09-06 15:54:32]

lgtm

https://codereview.chromium.org/2313823002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_history/searched_label.js (right):

https://codereview.chromium.org/2313823002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_history/searched_label.js:36: if (match.index > i)
nit: curlies

https://codereview.chromium.org/2313823002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_history/searched_label.js:46: this.appendChild(
nit: curlies