Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2313823002: MD History: Remove shadow root from <history-searched-label> (Closed)

Created:
4 years, 3 months ago by tsergeant
Modified:
4 years, 3 months ago
Reviewers:
calamity, Dan Beam
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Remove shadow root from <history-searched-label> The <history-searched-label> element directly modifies its own DOM without using a template or styling. The <template> and corresponding shadow root can be removed without affecting the functionality of the element. Removing these saves one shadow root and one div per <history-item> element, which has a very minor performance impact while also simplifying the element. BUG=629710 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/5e1f45d8c5fff4a1e635616bace6ce4f6ec3aa78 Cr-Commit-Position: refs/heads/master@{#416603}

Patch Set 1 #

Patch Set 2 : Fix tests #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -37 lines) Patch
M chrome/browser/resources/md_history/app.crisper.js View 6 chunks +21 lines, -21 lines 0 comments Download
M chrome/browser/resources/md_history/app.vulcanized.html View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/md_history/searched_label.html View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/md_history/searched_label.js View 1 chunk +5 lines, -6 lines 2 comments Download
M chrome/test/data/webui/md_history/history_list_test.js View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/webui/md_history/history_synced_tabs_test.js View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
tsergeant
4 years, 3 months ago (2016-09-06 00:16:35 UTC) #7
calamity
lgtm
4 years, 3 months ago (2016-09-06 06:53:07 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2313823002/20001
4 years, 3 months ago (2016-09-06 07:39:59 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-06 07:43:28 UTC) #17
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/5e1f45d8c5fff4a1e635616bace6ce4f6ec3aa78 Cr-Commit-Position: refs/heads/master@{#416603}
4 years, 3 months ago (2016-09-06 07:45:03 UTC) #19
Dan Beam
4 years, 3 months ago (2016-09-06 15:54:32 UTC) #21
Message was sent while issue was closed.
lgtm

https://codereview.chromium.org/2313823002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_history/searched_label.js (right):

https://codereview.chromium.org/2313823002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_history/searched_label.js:36: if (match.index > i)
nit: curlies

https://codereview.chromium.org/2313823002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_history/searched_label.js:46: this.appendChild(
nit: curlies

Powered by Google App Engine
This is Rietveld 408576698