Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 2313783003: Revert of Reland 'Add buildbot metadata to compiler_proxy log' (Closed)

Created:
4 years, 3 months ago by shinyak
Modified:
4 years, 3 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Reland 'Add buildbot metadata to compiler_proxy log' (patchset #2 id:20001 of https://codereview.chromium.org/2311123002/ ) Reason for revert: -h still not working: ArgumentException: Invalid header specifed Original issue's description: > Reland 'Add buildbot metadata to compiler_proxy log' > > We'd like to analyze compiler proxy log. However, buildbot metadata is > missing, so sometimes hard to determine in which builder the compiler > proxy log is generated. > > Append buildbot metadata to compiler_proxy log like ninja log. > > The difference from the previous patch is to add '--' to gsutil.py. > Without '--', gsutil.py consumes options which is expected to pass > to gsutil itself. > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/3437df739c975cec15fe81d6adfed5c0fbdf2c6c TBR=yyanagisawa@chromium.org,ukai@chromium.org,tikuta@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://chromium.googlesource.com/chromium/tools/build/+/edd1455b5b82f864701dcbf581aa0b7011ecb98e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -37 lines) Patch
M scripts/slave/compile.py View 3 chunks +4 lines, -11 lines 0 comments Download
M scripts/slave/goma_utils.py View 5 chunks +5 lines, -26 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
shinyak
Created Revert of Reland 'Add buildbot metadata to compiler_proxy log'
4 years, 3 months ago (2016-09-06 08:46:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2313783003/1
4 years, 3 months ago (2016-09-06 08:46:30 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 08:46:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/edd1455b5b82f864701d...

Powered by Google App Engine
This is Rietveld 408576698