Show a local folder's size in QuickView.

ui/file_manager/file_manager/foreground/js/metadata_box_controller.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * Controller of metadata box.
  *
  * @param{!MetadataModel} metadataModel
  * @param{!FilesMetadataBox} metadataBox
  * @param{!FilesQuickView} quickView
@@ skipping 22 matching lines @@
    * @private
    */
   this.quickView_ = quickView;
 
   /**
    * @type {!FileMetadataFormatter}
    * @private
    */
   this.fileMetadataFormatter_ = fileMetadataFormatter;
 
+  /**
+   * @type {Promise.<number>}

[fukino, 2016/09/06 09:12:45]

We don't need '.'. Use Promise<number>

[harukam, 2016/09/06 11:25:24]

Acknowledged.

+   * @private
+   */
+  this.directorySizePromise_ = null;
+
   // TODO(oka): Add storage to persist the value of
   // quickViewModel_.metadataBoxActive.
   /**
    * @type {!QuickViewModel}
    * @private
    */
   this.quickViewModel_ = quickViewModel;
 
   fileMetadataFormatter.addEventListener(
       'date-time-format-changed', this.updateView_.bind(this));
@@ skipping 30 matching lines @@
       .get(
           [entry], MetadataBoxController.GENERAL_METADATA_NAME.concat(
                        ['hosted', 'externalFileUrl']))
       .then(this.onGeneralMetadataLoaded_.bind(this, entry));
 };
 
 /**
  * Update metadata box with general file information.
  * Then retrieve file specific metadata if any.
  *
- * @param {!FileEntry} entry
+ * @param {!Entry} entry
  * @param {!Array<!MetadataItem>} items
  *
  * @private
  */
 MetadataBoxController.prototype.onGeneralMetadataLoaded_ = function(
     entry, items) {
   var type = FileType.getType(entry).type;
   var item = items[0];
 
   this.metadataBox_.type = type;
   if (item.size) {
     this.metadataBox_.size =
         this.fileMetadataFormatter_.formatSize(item.size, item.hosted);
   }
+  if (entry.isDirectory) {
+    this.setDirectorySize_(new Promise(function(resolve, reject) {

[fukino, 2016/09/06 09:12:45]

I think it is better to simply call this.setDirectorySize_(entry) and move the
implementation inside setDirectorySize_.

[harukam, 2016/09/06 11:25:24]

OK. Thanks.

+      chrome.fileManagerPrivate.getDirectorySize(
+          /** @type {!DirectoryEntry} */ (entry),
+          function(size) {
+            if(chrome.runtime.lastError)
+              reject();
+            else
+              resolve(size);
+          });
+    }));
+  }
   if (item.modificationTime) {
     this.metadataBox_.modificationTime =
         this.fileMetadataFormatter_.formatModDate(item.modificationTime);
   }
 
   if (item.externalFileUrl) {
     this.metadataModel_.get([entry], ['contentMimeType']).then(function(items) {
       var item = items[0];
       this.metadataBox_.mediaMimeType = item.contentMimeType;
     }.bind(this));
@@ skipping 22 matching lines @@
           .then(function(items) {
             var item = items[0];
             this.metadataBox_.imageHeight = item.imageHeight;
             this.metadataBox_.imageWidth = item.imageWidth;
             this.metadataBox_.mediaArtist = item.mediaArtist;
             this.metadataBox_.mediaTitle = item.mediaTitle;
           }.bind(this));
     }
   }
 };
+
+/**
+ * Set a directory size in metadata box.
+ *
+ * @param {Promise.<number>} directorySizePromise
+ *
+ * @private
+ */
+MetadataBoxController.prototype.setDirectorySize_ = function(
+    directorySizePromise) {
+  this.directorySizePromise_ = directorySizePromise;

[fukino, 2016/09/06 09:12:45]

If you avoid showing the size of the wrong entry, I think keeping track of Entry
instead of the promise will be easier to understand. 

[harukam, 2016/09/06 11:25:24]

Acknowledged.

+  if (!directorySizePromise)
+    return;
+
+  this.metadataBox_.setLoading(true);
+  directorySizePromise.then(function(size) {
+    if(this.directorySizePromise_ != directorySizePromise)
+      return;
+    this.metadataBox_.setLoading(false);
+    this.metadataBox_.size =
+        this.fileMetadataFormatter_.formatSize(size, true);
+  }.bind(this)).catch(function(error) {
+    if(this.directorySizePromise_ != directorySizePromise)
+      return;
+    this.metadataBox_.setLoading(false);
+  }.bind(this));
+};