Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issue 2313763002: [Interpreter] Add some CHECKS to track down crbug.com/642111 (Closed)

Created:
4 years, 3 months ago by rmcilroy
Modified:
4 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Add some CHECKS to track down crbug.com/642111 BUG=chromium:642111 Committed: https://crrev.com/d0e7d41f1cfa696fea44e2322e9861b92de9982a Cr-Commit-Position: refs/heads/master@{#39197}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M src/interpreter/bytecodes.cc View 4 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
rmcilroy
Michi: PTAL, thanks.
4 years, 3 months ago (2016-09-05 16:24:39 UTC) #2
Michael Starzinger
LGTM (rubber-stamped). I assume the intentions is to turn them back into DCHECKs after the ...
4 years, 3 months ago (2016-09-06 07:47:50 UTC) #3
rmcilroy
On 2016/09/06 07:47:50, Michael Starzinger wrote: > LGTM (rubber-stamped). I assume the intentions is to ...
4 years, 3 months ago (2016-09-06 08:43:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2313763002/1
4 years, 3 months ago (2016-09-06 08:43:54 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-06 09:07:30 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 09:07:48 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d0e7d41f1cfa696fea44e2322e9861b92de9982a
Cr-Commit-Position: refs/heads/master@{#39197}

Powered by Google App Engine
This is Rietveld 408576698