Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2313723007: Merged: Disallow tail calls from async functions and generators (Closed)

Created:
4 years, 3 months ago by Dan Ehrenberg
Modified:
4 years, 3 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan
Target Ref:
refs/pending/branch-heads/5.4
Project:
v8
Visibility:
Public.

Description

Merged: Disallow tail calls from async functions and generators Revision: 5af4cd984067f4e316aea04ef381a00724b5a8bf BUG=chromium:639270, v8:5301 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=adamk@chromium.org, adamk Committed: https://chromium.googlesource.com/v8/v8/+/51c8996ee36aaee5f5fee04b0747ea27194937b7

Patch Set 1 #

Patch Set 2 : Fix in local build #

Patch Set 3 : new version correctly based #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M src/parsing/parser.cc View 2 1 chunk +1 line, -1 line 0 comments Download
M src/parsing/parser-base.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M test/mjsunit/es8/syntactic-tail-call-parsing.js View 4 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 24 (17 generated)
Dan Ehrenberg
4 years, 3 months ago (2016-09-06 18:29:28 UTC) #1
Dan Ehrenberg
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
4 years, 3 months ago (2016-09-06 18:29:30 UTC) #2
adamk
It looks to me like you passed --branch 5.4.524 instead of --branch 5.4. If I'm ...
4 years, 3 months ago (2016-09-06 20:17:40 UTC) #15
Dan Ehrenberg
On 2016/09/06 at 20:17:40, adamk wrote: > It looks to me like you passed --branch ...
4 years, 3 months ago (2016-09-06 21:43:26 UTC) #20
adamk
lgtm
4 years, 3 months ago (2016-09-06 21:45:33 UTC) #21
Dan Ehrenberg
Committed patchset #3 (id:40001) manually as 51c8996ee36aaee5f5fee04b0747ea27194937b7.
4 years, 3 months ago (2016-09-06 21:48:26 UTC) #23
Dan Ehrenberg
4 years, 3 months ago (2016-09-06 22:06:43 UTC) #24
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2317873002/ by littledan@chromium.org.

The reason for reverting is: Mistaken revert to the wrong base.

Powered by Google App Engine
This is Rietveld 408576698