[parser] Simplify parse-time function name inference for properties

[parser] Simplify parse-time function name inference for properties

Move the code to perform function name inference for properties into
parsing the properties themselves, instead of the containing object.

This allows us to avoid unnecessary calls when parsing shorthand
properties and methods and simplifies the logic in the remaining cases.

Also fixes an edge case bug: inferring the name of the getter in
`class { static get constructor(){} }`.

Committed: https://crrev.com/2aab10f5b329a569de91ac36bcd28e4a6a9941aa
Cr-Commit-Position: refs/heads/master@{#39222}

[bakkot, 2016-09-06 17:55:52]

Description was changed from

==========
[parser] Simplify parse-time function name inference for properties

Move the code to perform function name inference for properties into
parsing the properties themselves, instead of the containing object.

This allows us to avoid unnecessary calls when parsing shorthand
properties and methods and simplifies the logic in the remaining cases.

BUG=
==========

to

==========
[parser] Simplify parse-time function name inference for properties

Move the code to perform function name inference for properties into
parsing the properties themselves, instead of the containing object.

This allows us to avoid unnecessary calls when parsing shorthand
properties and methods and simplifies the logic in the remaining cases.

Also fixes an edge case bug: inferring the name of the getter in
`class { static get constructor(){} }`.
==========

[bakkot, 2016-09-06 17:55:52]

bakkot@google.com changed reviewers:
+ adamk@chromium.org, littledan@chromium.org

[bakkot, 2016-09-06 18:06:35]

PTAL and add other reviewers as appropriate.

Afaict, SetFunctionNameFromPropertyName is only necessary in two cases: setting
the name of the
function in `({ a : function(){} })` and adding `get ` to the name of the
accessor in
`({ get a(){} })`. However it's called for every property, including shorthand
methods (which
already have the name set correctly) and shorthand properties (which it doesn't
need to handle).
This makes the logic more complicated than it needs to be.

It's much simpler to perform this work when parsing properties, instead of when
parsing objects.

[adamk, 2016-09-06 18:18:52]

lgtm

[bakkot, 2016-09-06 18:22:48]

The CQ bit was checked by bakkot@google.com

[commit-bot: I haz the power, 2016-09-06 18:22:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 18:49:12]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-06 18:49:58]

Description was changed from

==========
[parser] Simplify parse-time function name inference for properties

Move the code to perform function name inference for properties into
parsing the properties themselves, instead of the containing object.

This allows us to avoid unnecessary calls when parsing shorthand
properties and methods and simplifies the logic in the remaining cases.

Also fixes an edge case bug: inferring the name of the getter in
`class { static get constructor(){} }`.
==========

to

==========
[parser] Simplify parse-time function name inference for properties

Move the code to perform function name inference for properties into
parsing the properties themselves, instead of the containing object.

This allows us to avoid unnecessary calls when parsing shorthand
properties and methods and simplifies the logic in the remaining cases.

Also fixes an edge case bug: inferring the name of the getter in
`class { static get constructor(){} }`.

Committed: https://crrev.com/2aab10f5b329a569de91ac36bcd28e4a6a9941aa
Cr-Commit-Position: refs/heads/master@{#39222}
==========

[commit-bot: I haz the power, 2016-09-06 18:49:58]

Patchset 1 (id:??) landed as
https://crrev.com/2aab10f5b329a569de91ac36bcd28e4a6a9941aa
Cr-Commit-Position: refs/heads/master@{#39222}