cocoa: flip window controls and profile switcher for RTL

chrome/browser/ui/cocoa/browser_window_layout.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/browser_window_layout.h"
 
 #include <math.h>
 #include <string.h>
 
+#include "base/i18n/rtl.h"
 #include "base/logging.h"
 #include "base/mac/mac_util.h"
 #import "chrome/browser/ui/cocoa/tabs/tab_strip_controller.h"
 
 namespace chrome {
 
 // The height of the tab strip.
 const CGFloat kTabStripHeight = 37;
 
 }  // namespace chrome
@@ skipping 170 matching lines @@
       0, maxY_ - chrome::kTabStripHeight, width, chrome::kTabStripHeight);
   maxY_ = NSMinY(layout.frame);
 
   // In Yosemite, there is no longer an exit fullscreen button in the top-right
   // corner of the OSX Menu Bar. Instead, a Cocoa application's toolbar is
   // expected to have traffic lights. Chrome doesn't use an NSToolbar, so it
   // needs to manually add the traffic lights to the tab strip.
   layout.addCustomWindowControls =
       parameters_.inAnyFullscreen && parameters_.isOSYosemiteOrLater;
 
-  // Set left indentation based on fullscreen mode status.
-  if (!parameters_.inAnyFullscreen || layout.addCustomWindowControls)
-    layout.leftIndent = [TabStripController defaultLeftIndentForControls];
-
   // Lay out the icognito/avatar badge because calculating the indentation on
   // the right depends on it.
   if (parameters_.shouldShowAvatar) {
     CGFloat badgeXOffset = -kAvatarRightOffset;
     CGFloat badgeYOffset = 0;
     CGFloat buttonHeight = parameters_.avatarSize.height;
 
     if (parameters_.shouldUseNewAvatar) {
       // The fullscreen icon (if present) is displayed to the right of the
       // new style profile button.
       if (!NSIsEmptyRect(parameters_.fullscreenButtonFrame))
         badgeXOffset = -kLocationBarRightOffset;
 
       // Center the button, but make sure that it's pixel aligned on non-retina
       // displays. Use trunc() instead of round() to mimic the behavior of
       // autoresizesSubviews.
       badgeYOffset = trunc((chrome::kTabStripHeight - buttonHeight) / 2);
     } else {
       // Actually place the badge *above* |maxY|, by +2 to miss the divider.
       badgeYOffset = 2 * parameters_.avatarLineWidth;
     }
 
     NSSize size = NSMakeSize(parameters_.avatarSize.width,
                              std::min(buttonHeight, chrome::kTabStripHeight));
-    NSPoint origin =
-        NSMakePoint(width - parameters_.avatarSize.width + badgeXOffset,
-                    maxY_ + badgeYOffset);
+    NSPoint origin;
+    if (base::i18n::IsRTL()) {
+      origin = NSMakePoint(-badgeXOffset, maxY_ + badgeYOffset);
+    } else {
+      origin = NSMakePoint(width - parameters_.avatarSize.width + badgeXOffset,
+                           maxY_ + badgeYOffset);
+    }
     layout.avatarFrame =
         NSMakeRect(origin.x, origin.y, size.width, size.height);
   }
 
+  // Set left indentation based on fullscreen mode status.
+  if (!parameters_.inAnyFullscreen || layout.addCustomWindowControls) {
+    if (base::i18n::IsRTL())
+      layout.leftIndent = NSMaxX(layout.avatarFrame);
+    else
+      layout.leftIndent = [TabStripController defaultLeftIndentForControls];
+  }
+
   // Calculate the right indentation.
   // On 10.7 Lion to 10.9 Mavericks, there will be a fullscreen button when not
   // in fullscreen mode.
   // There may also be a profile button, which can be on the right of the
   // fullscreen button (old style), or to its left (new style).
   // The right indentation is calculated to prevent the tab strip from
   // overlapping these buttons.
-  CGFloat maxX = width;
-  if (!NSIsEmptyRect(parameters_.fullscreenButtonFrame)) {
-    maxX = NSMinX(parameters_.fullscreenButtonFrame);
+  if (base::i18n::IsRTL()) {
+    layout.rightIndent = [TabStripController defaultLeftIndentForControls];
+  } else {
+    CGFloat maxX = width;
+    if (!NSIsEmptyRect(parameters_.fullscreenButtonFrame)) {
+      maxX = NSMinX(parameters_.fullscreenButtonFrame);
+    }
+    if (parameters_.shouldShowAvatar) {
+      maxX = std::min(maxX, NSMinX(layout.avatarFrame));
+    }
+    layout.rightIndent = width - maxX;

[Avi (use Gerrit), 2016/09/06 15:38:00]

Some thoughts.

I would have thought that the code would be:
---
CGFloat leftIndent = ...
CGFloat rightIndent = ...
if (base::i18n::IsRTL())
  std::swap(leftIndent, rightIndent);
---

You take the old fullscreen button size into account only in non-RTL layout. Are
we ignoring that for RTL? Are we assuming that we're not going into RTL mode on
those older systems?

   }
-  if (parameters_.shouldShowAvatar) {
-    maxX = std::min(maxX, NSMinX(layout.avatarFrame));
-  }
-  layout.rightIndent = width - maxX;
 
   output_.tabStripLayout = layout;
 }
 
 - (void)computeContentViewLayout {
   chrome::LayoutParameters parameters = parameters_;
   CGFloat maxY = maxY_;
 
   // Sanity-check |maxY|.
   DCHECK_GE(maxY, 0);
@@ skipping 126 matching lines @@
 
 @end
 
 @implementation BrowserWindowLayout (ExposedForTesting)
 
 - (void)setOSYosemiteOrLater:(BOOL)osYosemiteOrLater {
   parameters_.isOSYosemiteOrLater = osYosemiteOrLater;
 }
 
 @end