Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2313723003: Call DocumentLoader::endWriting() when loading failed (Closed)

Created:
4 years, 3 months ago by hiroshige
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews, blink-reviews, loading-reviews_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Call DocumentLoader::endWriting() when loading failed DocumentLoader::endWriting() was called when the loading of the main document successfully finished, but not when the loading failed. In the case of ImageDocument, this caused ImageResource to remain pending and caused memory leak. BUG=640886, 632495

Patch Set 1 #

Patch Set 2 : Check m_writer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/Source/core/loader/DocumentLoader.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 1 (1 generated)
hiroshige
4 years, 3 months ago (2016-09-06 05:23:10 UTC) #1 
Description was changed from

==========
Call DocumentLoader::endWriting() when loading failed

BUG=
==========

to

==========
Call DocumentLoader::endWriting() when loading failed

DocumentLoader::endWriting() was called when the loading of the main document
successfully finished, but not when the loading failed.
In the case of ImageDocument, this caused ImageResource to remain pending and
caused memory leak.

BUG=640886, 632495
==========

Powered by Google App Engine
This is Rietveld 408576698