| Index: tools/perf/benchmarks/v8.py
|
| diff --git a/tools/perf/benchmarks/v8.py b/tools/perf/benchmarks/v8.py
|
| index 64adedec7871e810a3da0c4b15c35e4494924bea..ba0539fb7fdb5b02cc34f4e71ea49718cdcad95f 100644
|
| --- a/tools/perf/benchmarks/v8.py
|
| +++ b/tools/perf/benchmarks/v8.py
|
| @@ -2,7 +2,6 @@
|
| # Use of this source code is governed by a BSD-style license that can be
|
| # found in the LICENSE file.
|
| import os
|
| -import re
|
|
|
| from core import path_util
|
| from core import perf_benchmark
|
| @@ -15,7 +14,6 @@ from measurements import v8_gc_times
|
| import page_sets
|
| from telemetry import benchmark
|
| from telemetry import story
|
| -from telemetry.timeline import chrome_trace_config
|
| from telemetry.timeline import chrome_trace_category_filter
|
| from telemetry.web_perf import timeline_based_measurement
|
|
|
| @@ -198,91 +196,6 @@ class V8MobileInfiniteScroll(_InfiniteScrollBenchmark):
|
| possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X')
|
|
|
|
|
| -class _V8MemoryAndCodeSizeBenchmark(perf_benchmark.PerfBenchmark):
|
| - """Base class for benchmarks measuring code size."""
|
| -
|
| - _IGNORED_V8_STATS_RE = re.compile(
|
| - r'(?<!dump)(?<!process)_(std|count|min|sum|pct_\d{4}(_\d+)?)$')
|
| -
|
| - def CreateTimelineBasedMeasurementOptions(self):
|
| - category_filter = chrome_trace_category_filter.ChromeTraceCategoryFilter(
|
| - '-*, disabled-by-default-memory-infra,'
|
| - # TODO(crbug.com/616441, primiano): Remove this temporary workaround,
|
| - # which enables memory-infra V8 code stats in V8 code size benchmarks
|
| - # only (to not slow down detailed memory dumps in other benchmarks).
|
| - 'disabled-by-default-memory-infra.v8.code_stats')
|
| - options = timeline_based_measurement.Options(category_filter)
|
| - # Trigger periodic light memory dumps every 20 ms.
|
| - memory_dump_config = chrome_trace_config.MemoryDumpConfig()
|
| - memory_dump_config.AddTrigger('light', 20)
|
| - options.config.chrome_trace_config.SetMemoryDumpConfig(memory_dump_config)
|
| - options.SetTimelineBasedMetrics(['memoryMetric'])
|
| - return options
|
| -
|
| - page_set = page_sets.Top10MobileMemoryPageSet
|
| -
|
| - @classmethod
|
| - def ShouldTearDownStateAfterEachStoryRun(cls):
|
| - return True
|
| -
|
| - @classmethod
|
| - def ValueCanBeAddedPredicate(cls, value, is_first_result):
|
| - # TODO(crbug.com/610962): Remove this stopgap when the perf dashboard
|
| - # is able to cope with the data load generated by TBMv2 metrics.
|
| - if 'memory' not in value.name:
|
| - return True # Keep all non-memory values.
|
| - # TODO(petrcermak): Remove the 'subsystem' disjunct once
|
| - # https://codereview.chromium.org/2018503002/ lands in Catapult and rolls
|
| - # into Chromium.
|
| - if (('subsystem' in value.name or 'reported_by_chrome' in value.name) and
|
| - 'v8' not in value.name):
|
| - return False # Drop non-V8 values reported by Chrome.
|
| - # Keep dump counts and average+max of process counts, vmstats and v8.
|
| - return not cls._IGNORED_V8_STATS_RE.search(value.name)
|
| -
|
| -
|
| -@benchmark.Enabled('android')
|
| -class V8MobileCodeSizeIgnition(_V8MemoryAndCodeSizeBenchmark):
|
| - """Measures V8 heap and code size with ignition enabled on mobile web pages.
|
| -
|
| - http://www.chromium.org/developers/design-documents/rendering-benchmarks
|
| - """
|
| -
|
| - def SetExtraBrowserOptions(self, options):
|
| - super(V8MobileCodeSizeIgnition, self).SetExtraBrowserOptions(options)
|
| - v8_helper.EnableIgnition(options)
|
| -
|
| - # crbug.com/639007
|
| - @classmethod
|
| - def ShouldDisable(cls, possible_browser):
|
| - if (possible_browser.browser_type == 'reference' and
|
| - possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X'):
|
| - return True
|
| -
|
| - @classmethod
|
| - def Name(cls):
|
| - return 'top_10_mobile_memory_ignition'
|
| -
|
| -
|
| -@benchmark.Enabled('android')
|
| -class V8MobileCodeSize(_V8MemoryAndCodeSizeBenchmark):
|
| - """Measures V8 heap and code size on mobile web pages.
|
| -
|
| - http://www.chromium.org/developers/design-documents/rendering-benchmarks
|
| - """
|
| -
|
| - # crbug.com/639007
|
| - @classmethod
|
| - def ShouldDisable(cls, possible_browser):
|
| - if (possible_browser.browser_type == 'reference' and
|
| - possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X'):
|
| - return True
|
| -
|
| - @classmethod
|
| - def Name(cls):
|
| - return 'top_10_mobile_memory'
|
| -
|
| -
|
| class V8Adword(perf_benchmark.PerfBenchmark):
|
| """Measures V8 Execution metrics on the Adword page."""
|
|
|
|
|