Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 2313723002: [tools/perf] Remove top_10_mobile_memory[_ignition] benchmark. (Closed)

Created:
4 years, 3 months ago by rmcilroy
Modified:
4 years, 3 months ago
Reviewers:
nednguyen, ulan
CC:
chromium-reviews, telemetry-reviews_chromium.org, mythria
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tools/perf] Remove top_10_mobile_memory[_ignition] benchmark. This has now been replaced by the v8.browsing benchmark. BUG=v8:4280, v8:5019 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Committed: https://crrev.com/a31a1aaeb51182e61a48834591ec64d858ad9bf1 Cr-Commit-Position: refs/heads/master@{#416926}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -87 lines) Patch
M tools/perf/benchmarks/v8.py View 3 chunks +0 lines, -87 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
rmcilroy
PTAL, this removes the top_10_mobile_memory benchmarks as discussed (in favor of the v8.browsing benchmarks). Is ...
4 years, 3 months ago (2016-09-05 13:16:54 UTC) #3
nednguyen
lgtm but Ulan should take a look
4 years, 3 months ago (2016-09-06 15:08:17 UTC) #6
ulan
lgtm
4 years, 3 months ago (2016-09-07 09:29:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2313723002/1
4 years, 3 months ago (2016-09-07 10:17:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 13:36:23 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 13:39:42 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a31a1aaeb51182e61a48834591ec64d858ad9bf1
Cr-Commit-Position: refs/heads/master@{#416926}

Powered by Google App Engine
This is Rietveld 408576698