Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 2313713002: Revert of [regexp] Port RegExp getters and setters (Closed)

Created:
4 years, 3 months ago by jgruber
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [regexp] Port RegExp getters and setters (patchset #5 id:80001 of https://codereview.chromium.org/2305573002/ ) Reason for revert: Performance regressions: crbug.com/644087 Clusterfuzz: crbug.com/644074 We'll reland all regexp changes at once when the port is complete and at least performance-neutral, since the partial port requires slow workarounds. Original issue's description: > [regexp] Port RegExp getters and setters > > BUG=v8:5339 > > Committed: https://crrev.com/ac0eb5e05af40e16ae9402bb8a62600b32cc2ec9 > Committed: https://crrev.com/7711b1a16f864ed6ea56fa40274ff3f6287bbe34 > Cr-Original-Commit-Position: refs/heads/master@{#39076} > Cr-Commit-Position: refs/heads/master@{#39088} TBR=bmeurer@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:5339 Committed: https://crrev.com/ee7f14cb54541db624993c03f0993d32ba81f1f0 Cr-Commit-Position: refs/heads/master@{#39176}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+259 lines, -428 lines) Patch
M src/bootstrapper.cc View 3 chunks +24 lines, -148 lines 0 comments Download
M src/builtins/builtins.h View 1 chunk +0 lines, -23 lines 0 comments Download
M src/builtins/builtins-regexp.cc View 1 chunk +0 lines, -244 lines 0 comments Download
M src/heap-symbols.h View 5 chunks +0 lines, -5 lines 0 comments Download
M src/js/regexp.js View 3 chunks +224 lines, -3 lines 0 comments Download
M src/messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ForOf.golden View 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Generators.golden View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/messages.js View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jgruber
Created Revert of [regexp] Port RegExp getters and setters
4 years, 3 months ago (2016-09-05 13:10:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2313713002/1
4 years, 3 months ago (2016-09-05 13:10:49 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-05 13:48:27 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ee7f14cb54541db624993c03f0993d32ba81f1f0 Cr-Commit-Position: refs/heads/master@{#39176}
4 years, 3 months ago (2016-09-05 13:48:52 UTC) #7
Michael Achenbach
Did the original CL require layout test rebase? See: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/9540 If so, please land a ...
4 years, 3 months ago (2016-09-05 14:45:06 UTC) #8
jgruber
4 years, 3 months ago (2016-09-05 14:55:26 UTC) #9
Message was sent while issue was closed.
On 2016/09/05 14:45:06, machenbach (slow) wrote:
> Did the original CL require layout test rebase? See:
>
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui...
> 
> If so, please land a rebaseline request asap.

I still need to figure out which attributes we want for these getters/setters
(they've been ignored so far due to a bug in InstallGetterSetter:
https://codereview.chromium.org/2297193005/). I'll land a rebaseline request
once I know.

Powered by Google App Engine
This is Rietveld 408576698