Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 2313703002: Revert of [parser] Refactor of Parse*Statement*, part 1 (Closed)

Created:
4 years, 3 months ago by Michael Achenbach
Modified:
4 years, 3 months ago
Reviewers:
nickie, adamk, marja
CC:
v8-reviews_googlegroups.com, Dan Ehrenberg
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [parser] Refactor of Parse*Statement*, part 1 (patchset #2 id:20001 of https://codereview.chromium.org/2307073002/ ) Reason for revert: https://build.chromium.org/p/client.v8.ports/builders/V8%20Mips%20-%20builder Original issue's description: > [parser] Refactor of Parse*Statement*, part 1 > > This patch moves the following parsing methods to ParserBase: > > - ParseStatementList > - ParseStatementListItem > - ParseStatement > - ParseSubStatement (subsumed in ParseStatement) > - ParseStatementAsUnlabeled > > It also refactors the Target and TargetScope objects, used by the > parser. > > R=adamk@chromium.org, marja@chromium.org > BUG= > LOG=N > > Committed: https://crrev.com/df29f3fda25660075a273cc27ad9f7787f321072 > Cr-Commit-Position: refs/heads/master@{#39167} TBR=adamk@chromium.org,marja@chromium.org,nikolaos@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/02164afd8197c125f6ed69cf3b61b56115adf130 Cr-Commit-Position: refs/heads/master@{#39169}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+597 lines, -543 lines) Patch
M src/parsing/parser.h View 8 chunks +17 lines, -42 lines 0 comments Download
M src/parsing/parser.cc View 16 chunks +299 lines, -41 lines 0 comments Download
M src/parsing/parser-base.h View 6 chunks +1 line, -298 lines 0 comments Download
M src/parsing/preparser.h View 18 chunks +35 lines, -119 lines 0 comments Download
M src/parsing/preparser.cc View 21 chunks +245 lines, -43 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [parser] Refactor of Parse*Statement*, part 1
4 years, 3 months ago (2016-09-05 13:05:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2313703002/1
4 years, 3 months ago (2016-09-05 13:05:56 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-05 13:06:06 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-05 13:06:48 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/02164afd8197c125f6ed69cf3b61b56115adf130
Cr-Commit-Position: refs/heads/master@{#39169}

Powered by Google App Engine
This is Rietveld 408576698