Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 2313683002: Reland of [stubs] Port KeyedLoadIC_Generic stub to TurboFan (Closed)

Created:
4 years, 3 months ago by Jakob Kummerow
Modified:
4 years, 3 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com, Igor Sheludko
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of [stubs] Port KeyedLoadIC_Generic stub to TurboFan And also handle dictionary elements loads in the dispatcher. This is a reland with fix for negative indices into DICTIONARY_ELEMENTS. Original review: https://codereview.chromium.org/2245683002/ Committed: https://crrev.com/685be312032f444d8af03c80421b7733309926e1 Cr-Commit-Position: refs/heads/master@{#39172}

Patch Set 1 : original patch #

Patch Set 2 : rebased #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+330 lines, -74 lines) Patch
M src/builtins/builtins.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins/builtins-handler.cc View 1 1 chunk +15 lines, -0 lines 0 comments Download
M src/builtins/builtins-sharedarraybuffer.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/code-factory.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/code-stub-assembler.h View 1 2 chunks +13 lines, -5 lines 0 comments Download
M src/code-stub-assembler.cc View 1 2 8 chunks +266 lines, -68 lines 0 comments Download
M src/ic/handler-compiler.cc View 1 1 chunk +9 lines, -1 line 0 comments Download
A test/mjsunit/keyed-load-generic.js View 1 2 1 chunk +20 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
Jakob Kummerow
Created Reland of [stubs] Port KeyedLoadIC_Generic stub to TurboFan
4 years, 3 months ago (2016-09-05 12:09:02 UTC) #1
Jakob Kummerow
PTAL.
4 years, 3 months ago (2016-09-05 12:38:18 UTC) #5
Igor Sheludko
lgtm
4 years, 3 months ago (2016-09-05 12:39:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2313683002/200001
4 years, 3 months ago (2016-09-05 12:40:22 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:200001)
4 years, 3 months ago (2016-09-05 13:17:54 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-05 13:18:14 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/685be312032f444d8af03c80421b7733309926e1
Cr-Commit-Position: refs/heads/master@{#39172}

Powered by Google App Engine
This is Rietveld 408576698