Reland of Add groupid for media devices. Group audio devices.

Reland of Add groupid for media devices. Group audio devices. (patchset #1 id:1 of https://codereview.chromium.org/2296393004/ )

Reason for revert:
I'm fixing the threading issue now.

Original issue's description:
> Revert of Add groupid for media devices. Group audio devices. (patchset #5 id:80001 of https://codereview.chromium.org/2273653002/ )
>
> Reason for revert:
> Breaks webrtc FYI bots on mac https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/59143. I'll have to figure out what's up with that ¯\_(ツ)_/¯
>
> Original issue's description:
> > Add groupid for media devices. Group audio devices.
> >
> > At present, the renderer tries to use matched_output_device
> > to assign groupids to audio devices. matched_output_device isn't set
> > before devices are sent to the renderer, and we wouldn't be able to
> > handle all the cases with it anyways.
> >
> > BUG=636300, 627793
> >
> > Committed: https://crrev.com/f07d1047986130ef0277a87b5b0b6175c4362c98
> > Cr-Commit-Position: refs/heads/master@{#416140}
>
> TBR=guidou@chromium.org,tommi@chromium.org,nasko@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=636300, 627793
>
> Committed: https://crrev.com/0c747762e50c0452f7809fa48249a1a776ff43d2
> Cr-Commit-Position: refs/heads/master@{#416217}

TBR=guidou@chromium.org,tommi@chromium.org,nasko@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=636300, 627793
Committed: https://crrev.com/a4ec5769ae36fdd14e49207f30e0aa8dcdc2ac34
Cr-Commit-Position: refs/heads/master@{#416663}

[Max Morin, 2016-09-05 10:55:28]

Created Reland of Add groupid for media devices. Group audio devices.

[Max Morin, 2016-09-05 11:10:43]

Hello everyone. Please take another look at this CL for the (hopefully) last
time. :)

https://codereview.chromium.org/2313663002/diff/260001/content/browser/render...
File content/browser/renderer_host/media/audio_output_device_enumerator.cc
(right):

https://codereview.chromium.org/2313663002/diff/260001/content/browser/render...
content/browser/renderer_host/media/audio_output_device_enumerator.cc:53:
AudioOutputDeviceInfo::AudioOutputDeviceInfo() {}
This stuff had to be added because AudioOutputDeviceInfo became too complex for
default constructor et c.

[tommi (sloooow) - chröme, 2016-09-05 13:09:23]

https://codereview.chromium.org/2313663002/diff/260001/content/browser/render...
File content/browser/renderer_host/media/audio_output_device_enumerator.cc
(right):

https://codereview.chromium.org/2313663002/diff/260001/content/browser/render...
content/browser/renderer_host/media/audio_output_device_enumerator.cc:64:
group_id(group_id),
can group_id be const?

https://codereview.chromium.org/2313663002/diff/260001/content/browser/render...
File content/browser/renderer_host/media/audio_output_device_enumerator.h
(right):

https://codereview.chromium.org/2313663002/diff/260001/content/browser/render...
content/browser/renderer_host/media/audio_output_device_enumerator.h:47:
AudioOutputDeviceInfo(std::string unique_id,
are these all by-value on purpose?

[Guido Urdaneta, 2016-09-05 13:15:53]

https://codereview.chromium.org/2313663002/diff/260001/media/audio/audio_mana...
File media/audio/audio_manager.h (right):

https://codereview.chromium.org/2313663002/diff/260001/media/audio/audio_mana...
media/audio/audio_manager.h:247: // (see GetWorkerTaskRunner()).
Actually, the comment should say GetTaskRunner() instead of
GetWorkerTaskRunner().
Feel free to fix other instances if this as a drive-by.

[Max Morin, 2016-09-05 13:53:56]

PTAL

https://codereview.chromium.org/2313663002/diff/260001/content/browser/render...
File content/browser/renderer_host/media/audio_output_device_enumerator.cc
(right):

https://codereview.chromium.org/2313663002/diff/260001/content/browser/render...
content/browser/renderer_host/media/audio_output_device_enumerator.cc:64:
group_id(group_id),
On 2016/09/05 13:09:23, tommi (chrömium) wrote:
> can group_id be const?

It seems like base::PostTaskAndReplyWithResult used at
https://cs.chromium.org/chromium/src/content/browser/renderer_host/media/audi...
requires AudioOutputDeviceInfo to be copy-assignable.

https://codereview.chromium.org/2313663002/diff/260001/content/browser/render...
File content/browser/renderer_host/media/audio_output_device_enumerator.h
(right):

https://codereview.chromium.org/2313663002/diff/260001/content/browser/render...
content/browser/renderer_host/media/audio_output_device_enumerator.h:47:
AudioOutputDeviceInfo(std::string unique_id,
On 2016/09/05 13:09:23, tommi (chrömium) wrote:
> are these all by-value on purpose?

Fixed

https://codereview.chromium.org/2313663002/diff/260001/media/audio/audio_mana...
File media/audio/audio_manager.h (right):

https://codereview.chromium.org/2313663002/diff/260001/media/audio/audio_mana...
media/audio/audio_manager.h:247: // (see GetWorkerTaskRunner()).
On 2016/09/05 13:15:53, Guido Urdaneta wrote:
> Actually, the comment should say GetTaskRunner() instead of
> GetWorkerTaskRunner().
> Feel free to fix other instances if this as a drive-by.

Done.

[tommi (sloooow) - chröme, 2016-09-05 14:08:00]

lgtm

[Guido Urdaneta, 2016-09-05 14:08:37]

lgtm

[Max Morin, 2016-09-06 14:15:03]

The CQ bit was checked by maxmorin@chromium.org

[commit-bot: I haz the power, 2016-09-06 14:15:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Max Morin, 2016-09-06 14:16:00]

On 2016/09/05 14:08:37, Guido Urdaneta wrote:
> lgtm

nasko: I leave you as TBR since your files are unchanged from the original CL.

[commit-bot: I haz the power, 2016-09-06 17:57:30]

Committed patchset #4 (id:280001)

[commit-bot: I haz the power, 2016-09-06 17:59:39]

Description was changed from

==========
Reland of Add groupid for media devices. Group audio devices. (patchset #1 id:1
of https://codereview.chromium.org/2296393004/ )

Reason for revert:
I'm fixing the threading issue now.

Original issue's description:
> Revert of Add groupid for media devices. Group audio devices. (patchset #5
id:80001 of https://codereview.chromium.org/2273653002/ )
> 
> Reason for revert:
> Breaks webrtc FYI bots on mac
https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/59143.
I'll have to figure out what's up with that ¯\_(ツ)_/¯
> 
> Original issue's description:
> > Add groupid for media devices. Group audio devices.
> >
> > At present, the renderer tries to use matched_output_device
> > to assign groupids to audio devices. matched_output_device isn't set
> > before devices are sent to the renderer, and we wouldn't be able to
> > handle all the cases with it anyways.
> >
> > BUG=636300, 627793
> >
> > Committed: https://crrev.com/f07d1047986130ef0277a87b5b0b6175c4362c98
> > Cr-Commit-Position: refs/heads/master@{#416140}
> 
> TBR=guidou@chromium.org,tommi@chromium.org,nasko@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=636300, 627793
> 
> Committed: https://crrev.com/0c747762e50c0452f7809fa48249a1a776ff43d2
> Cr-Commit-Position: refs/heads/master@{#416217}

TBR=guidou@chromium.org,tommi@chromium.org,nasko@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=636300, 627793
==========

to

==========
Reland of Add groupid for media devices. Group audio devices. (patchset #1 id:1
of https://codereview.chromium.org/2296393004/ )

Reason for revert:
I'm fixing the threading issue now.

Original issue's description:
> Revert of Add groupid for media devices. Group audio devices. (patchset #5
id:80001 of https://codereview.chromium.org/2273653002/ )
>
> Reason for revert:
> Breaks webrtc FYI bots on mac
https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/59143.
I'll have to figure out what's up with that ¯\_(ツ)_/¯
>
> Original issue's description:
> > Add groupid for media devices. Group audio devices.
> >
> > At present, the renderer tries to use matched_output_device
> > to assign groupids to audio devices. matched_output_device isn't set
> > before devices are sent to the renderer, and we wouldn't be able to
> > handle all the cases with it anyways.
> >
> > BUG=636300, 627793
> >
> > Committed: https://crrev.com/f07d1047986130ef0277a87b5b0b6175c4362c98
> > Cr-Commit-Position: refs/heads/master@{#416140}
>
> TBR=guidou@chromium.org,tommi@chromium.org,nasko@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=636300, 627793
>
> Committed: https://crrev.com/0c747762e50c0452f7809fa48249a1a776ff43d2
> Cr-Commit-Position: refs/heads/master@{#416217}

TBR=guidou@chromium.org,tommi@chromium.org,nasko@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=636300, 627793

Committed: https://crrev.com/a4ec5769ae36fdd14e49207f30e0aa8dcdc2ac34
Cr-Commit-Position: refs/heads/master@{#416663}
==========

[commit-bot: I haz the power, 2016-09-06 17:59:41]

Patchset 4 (id:??) landed as
https://crrev.com/a4ec5769ae36fdd14e49207f30e0aa8dcdc2ac34
Cr-Commit-Position: refs/heads/master@{#416663}

[Max Morin, 2016-09-07 07:31:51]

Thanks for the reviews everyone!