Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2313653004: Make a pen in eraser mode visible thru PointerEvent.buttons (Closed)

Created:
4 years, 3 months ago by mustaq
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Make a pen in eraser mode visible thru PointerEvent.buttons The PointerEvent spec can't gracefully support a hovering pen in eraser mode because a non-zero |buttons| field indicate an active buttons state. The issue is currently being discussed in github: https://github.com/w3c/pointerevents/issues/134 Until the spec gets fixed, this CL exposes the eraser mode in a spec-compliant way by hiding the eraser mode until the pen touches the digitizer. Edge shows the same behavior. This CL also adds X1, X2 & Eraser button/buttons values to WebPointerProperties. BUG=642455 Review-Url: https://codereview.chromium.org/2296303002 Cr-Commit-Position: refs/heads/master@{#416360} (cherry picked from commit 758b11555d5e65c63258731d4fc72b7d7edea0d7) Committed: https://chromium.googlesource.com/chromium/src/+/956dc72f92984d993e390491c90b283beda8b89c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+357 lines, -52 lines) Patch
M components/test_runner/event_sender.cc View 3 chunks +13 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-event-properties.html View 5 chunks +42 lines, -25 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-event-properties-expected.txt View 2 chunks +255 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/MouseEvent.h View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/events/MouseEvent.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/events/PointerEventFactory.cpp View 4 chunks +30 lines, -9 lines 0 comments Download
M third_party/WebKit/public/platform/WebPointerProperties.h View 1 chunk +14 lines, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
mustaq
Committed patchset #1 (id:1) manually as 956dc72f92984d993e390491c90b283beda8b89c.
4 years, 3 months ago (2016-09-06 14:50:34 UTC) #2
mustaq
4 years, 3 months ago (2016-09-06 16:07:06 UTC) #3
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2314093002/ by mustaq@chromium.org.

The reason for reverting is: Broke the build..

Powered by Google App Engine
This is Rietveld 408576698