content/browser/service_worker/embedded_worker_instance_unittest.cc - Issue 2313653002: ServiceWorker: Exchange InterfaceProviders when starting worker thread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/embedded_worker_instance_unittest.cc

Issue 2313653002: ServiceWorker: Exchange InterfaceProviders when starting worker thread (Closed)

Patch Set: Updated comments and fixed a typo Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/embedded_worker_instance.cc ('k') | content/browser/service_worker/embedded_worker_test_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/embedded_worker_instance_unittest.cc

diff --git a/content/browser/service_worker/embedded_worker_instance_unittest.cc b/content/browser/service_worker/embedded_worker_instance_unittest.cc

index ed332f66bfffc3da944e1b02a023336e002f83fc..08fa4dd6780bf3749f2650c851553dad65f78908 100644

--- a/content/browser/service_worker/embedded_worker_instance_unittest.cc

+++ b/content/browser/service_worker/embedded_worker_instance_unittest.cc

@@ -726,7 +726,10 @@ class FailEmbeddedWorkerInstanceClientImpl

: EmbeddedWorkerTestHelper::MockEmbeddedWorkerInstanceClient(helper) {}

private:

- void StartWorker(const EmbeddedWorkerStartParams& /* unused */) override {

+ void StartWorker(

+ const EmbeddedWorkerStartParams& /* unused */,

+ service_manager::mojom::InterfaceProviderPtr /* unused */,

+ service_manager::mojom::InterfaceProviderRequest /* unused */) override {

helper_->mock_instance_clients()->clear();

}

};