Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(245)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: third_party/WebKit/LayoutTests/custom-elements/spec/state-failed-upgrade-expected.txt
Issue
2313573002
:
Custom Elements: add prototype check for "failed" elements (Closed)
Patch Set: template.html clean up
Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
third_party/WebKit/LayoutTests/custom-elements/spec/create-element-inside-template.html
third_party/WebKit/LayoutTests/custom-elements/spec/state-failed-create.html
third_party/WebKit/LayoutTests/custom-elements/spec/state-failed-upgrade.html
third_party/WebKit/LayoutTests/custom-elements/spec/state-failed-upgrade-expected.txt
View unified diff
|
Download patch
« no previous file with comments
|
« third_party/WebKit/LayoutTests/custom-elements/spec/state-failed-upgrade.html
('k') |
no next file »
|
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
CONSOLE ERROR: line 21: Uncaught Error
2
CONSOLE ERROR: line 2445: Uncaught Error: assert_unreached: connectedCallback sh ould not be invoked if constructor threw Reached unreachable code
3
This is a testharness.js-based test.
4
PASS Custom Elements: Custom Element State "Failed" in Upgrades
5
Harness: the test ran to completion.
6
OLD
NEW
« no previous file with comments
|
« third_party/WebKit/LayoutTests/custom-elements/spec/state-failed-upgrade.html
('k') |
no next file »
|
no next file with comments »
Issue 2313573002: Custom Elements: add prototype check for "failed" elements (Closed)
Created 4 years, 3 months ago by davaajav
Modified 4 years, 3 months ago
Reviewers: dominicc (has gone to gerrit), kojii
Base URL:
Comments: 4
This is Rietveld
408576698