components/favicon_base/favicon_util.h - Issue 2313563002: Reduce jank from favicon downscaling.

Side by Side Diff: components/favicon_base/favicon_util.h

Issue 2313563002: Reduce jank from favicon downscaling. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « components/favicon/core/favicon_service.cc ('k') | components/favicon_base/favicon_util.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef COMPONENTS_FAVICON_BASE_FAVICON_UTIL_H_	5 #ifndef COMPONENTS_FAVICON_BASE_FAVICON_UTIL_H_

6 #define COMPONENTS_FAVICON_BASE_FAVICON_UTIL_H_	6 #define COMPONENTS_FAVICON_BASE_FAVICON_UTIL_H_

7	7

8 #include <vector>	8 #include <vector>

9	9

10 #include "components/favicon_base/favicon_types.h"	10 #include "components/favicon_base/favicon_types.h"

(...skipping 18 matching lines...) Expand all Loading...
29 void SetFaviconColorSpace(gfx::Image* image);	29 void SetFaviconColorSpace(gfx::Image* image);

30	30

31 // Takes a vector of PNG-encoded frames, and converts it to a gfx::Image of	31 // Takes a vector of PNG-encoded frames, and converts it to a gfx::Image of

32 // size \|favicon_size\| in DIPS. The result gfx::Image has a gfx::ImageSkia with	32 // size \|favicon_size\| in DIPS. The result gfx::Image has a gfx::ImageSkia with

33 // gfx::ImageSkiaReps for each \|favicon_scales\|.	33 // gfx::ImageSkiaReps for each \|favicon_scales\|.

34 gfx::Image SelectFaviconFramesFromPNGs(	34 gfx::Image SelectFaviconFramesFromPNGs(

35 const std::vector<favicon_base::FaviconRawBitmapResult>& png_data,	35 const std::vector<favicon_base::FaviconRawBitmapResult>& png_data,

36 const std::vector<float>& favicon_scales,	36 const std::vector<float>& favicon_scales,

37 int favicon_size);	37 int favicon_size);

38	38

	39 favicon_base::FaviconRawBitmapResult ShoehornFaviconToSize(
	sky 2016/09/06 20:19:39 Showhorn? ResizeFaviconBitmapResult? Showhorn? ResizeFaviconBitmapResult? aelias_OOO_until_Jul13 2016/09/06 20:46:42 I wanted to use a pejorative word, so I renamed to Show quoted text On 2016/09/06 at 20:19:39, sky wrote: > Showhorn? ResizeFaviconBitmapResult? I wanted to use a pejorative word, so I renamed to ResizeFaviconResultSlow. sky 2016/09/06 21:50:45 That argument could be applied to any function tha Show quoted text On 2016/09/06 20:46:42, aelias wrote: > On 2016/09/06 at 20:19:39, sky wrote: > > Showhorn? ResizeFaviconBitmapResult? > > I wanted to use a pejorative word, so I renamed to ResizeFaviconResultSlow. That argument could be applied to any function that could take a while. Resizing is inherently slow. I prefer no 'slow' here. aelias_OOO_until_Jul13 2016/09/06 22:10:49 OK, done. Show quoted text On 2016/09/06 at 21:50:45, sky wrote: > On 2016/09/06 20:46:42, aelias wrote: > > On 2016/09/06 at 20:19:39, sky wrote: > > > Showhorn? ResizeFaviconBitmapResult? > > > > I wanted to use a pejorative word, so I renamed to ResizeFaviconResultSlow. > > That argument could be applied to any function that could take a while. Resizing is inherently slow. I prefer no 'slow' here. OK, done.
	40 const std::vector<favicon_base::FaviconRawBitmapResult>&

	41 favicon_bitmap_results,

	42 int desired_size_in_pixel);

	43

39 } // namspace favicon_base	44 } // namspace favicon_base

40	45

41 #endif // COMPONENTS_FAVICON_BASE_FAVICON_UTIL_H_	46 #endif // COMPONENTS_FAVICON_BASE_FAVICON_UTIL_H_

OLD	NEW