Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2313543002: ServiceWorker: Disable CHECK for debug (Closed)

Created:
4 years, 3 months ago by shimazu
Modified:
4 years, 3 months ago
Reviewers:
nhiroki
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Disable CHECK for debug Removes temporary CHECK added at https://crrev.com/2288613002 BUG=634222 Committed: https://crrev.com/4b6d694efc24392d1516551abfc1098dd6d97bc8 Cr-Commit-Position: refs/heads/master@{#416512}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M content/browser/service_worker/service_worker_provider_host.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
shimazu
ptal
4 years, 3 months ago (2016-09-05 04:30:09 UTC) #2
nhiroki
lgtm
4 years, 3 months ago (2016-09-05 05:24:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2313543002/1
4 years, 3 months ago (2016-09-05 05:53:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-05 07:21:03 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-05 07:22:23 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4b6d694efc24392d1516551abfc1098dd6d97bc8
Cr-Commit-Position: refs/heads/master@{#416512}

Powered by Google App Engine
This is Rietveld 408576698