Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issue 2313533002: Revert of Submit Compositor Frame from OffscreenCanvas on main (Closed)

Created:
4 years, 3 months ago by Matt Giuca
Modified:
4 years, 3 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, yzshen+watch_chromium.org, Stephen Chennney, rwlbuis, krit, drott+blinkwatch_chromium.org, jam, abarth-chromium, dglazkov+blink, Rik, darin-cc_chromium.org, blink-reviews, ajuma+watch_chromium.org, blink-reviews-api_chromium.org, jbroman, pdr+graphicswatchlist_chromium.org, haraken, danakj+watch_chromium.org, Aaron Boodman, f(malita), darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Submit Compositor Frame from OffscreenCanvas on main (patchset #10 id:200001 of https://codereview.chromium.org/2294963002/ ) Reason for revert: The new OffscreenCanvas-commit-main tests are broken on MSAN on Linux: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/builds/12023 Reason: use-of-uninitialized-value unexpected_failures: fast/canvas/OffscreenCanvas-commit-main.html virtual/gpu/fast/canvas/OffscreenCanvas-commit-main.html virtual/display_list_2d_canvas/fast/canvas/OffscreenCanvas-commit-main.html Original issue's description: > Submit Compositor Frame from OffscreenCanvas on main > > CompositorFrame is to be submitted from OffscreenCanvas from > either main or worker thread (but not both at the same time); > therefore, another interface "OffscreenCanvasFrameReceiver" > is created only when commit() is invoked. > > This CL follows the class design structure in this diagram: > www.lucidchart.com/documents/view/346a55cc-0ab1-48e8-9d34-90f59d36094e > > Currently, we only submit a Green color frame for simplicity. > More CLs will follow to fill in image data to the compositor > frame. > > BUG=563852 > > Committed: https://crrev.com/94a3a26405be3996569d9006b29d0460bb9e8dca > Cr-Commit-Position: refs/heads/master@{#416436} TBR=junov@chromium.org,danakj@chromium.org,tsepez@chromium.org,sievers@chromium.org,xlai@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=563852 Committed: https://crrev.com/ab7f06aeaff3d24a161eb1bbfa246839a362525f Cr-Commit-Position: refs/heads/master@{#416503}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -286 lines) Patch
M content/browser/renderer_host/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
D content/browser/renderer_host/offscreen_canvas_frame_receiver_impl.h View 1 chunk +0 lines, -36 lines 0 comments Download
D content/browser/renderer_host/offscreen_canvas_frame_receiver_impl.cc View 1 chunk +0 lines, -37 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-commit-main.html View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-commit-main-expected.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-transferControlToOffscreen.html View 2 chunks +29 lines, -35 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-transferControlToOffscreen-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.h View 3 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp View 3 chunks +0 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcher.h View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h View 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp View 1 chunk +0 lines, -55 lines 0 comments Download
M third_party/WebKit/public/platform/modules/offscreencanvas/offscreen_canvas_surface.mojom View 1 chunk +4 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Matt Giuca
Created Revert of Submit Compositor Frame from OffscreenCanvas on main
4 years, 3 months ago (2016-09-05 04:14:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2313533002/1
4 years, 3 months ago (2016-09-05 04:14:24 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-05 06:07:35 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-05 06:11:03 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ab7f06aeaff3d24a161eb1bbfa246839a362525f
Cr-Commit-Position: refs/heads/master@{#416503}

Powered by Google App Engine
This is Rietveld 408576698