Description was changed from ========== Revert of Submit Compositor Frame from OffscreenCanvas on main (patchset ...
4 years, 3 months ago
(2016-09-05 06:07:32 UTC)
#4
Message was sent while issue was closed.
Description was changed from
==========
Revert of Submit Compositor Frame from OffscreenCanvas on main (patchset #10
id:200001 of https://codereview.chromium.org/2294963002/ )
Reason for revert:
The new OffscreenCanvas-commit-main tests are broken on MSAN on Linux:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/b...
Reason: use-of-uninitialized-value
unexpected_failures:
fast/canvas/OffscreenCanvas-commit-main.html
virtual/gpu/fast/canvas/OffscreenCanvas-commit-main.html
virtual/display_list_2d_canvas/fast/canvas/OffscreenCanvas-commit-main.html
Original issue's description:
> Submit Compositor Frame from OffscreenCanvas on main
>
> CompositorFrame is to be submitted from OffscreenCanvas from
> either main or worker thread (but not both at the same time);
> therefore, another interface "OffscreenCanvasFrameReceiver"
> is created only when commit() is invoked.
>
> This CL follows the class design structure in this diagram:
> www.lucidchart.com/documents/view/346a55cc-0ab1-48e8-9d34-90f59d36094e
>
> Currently, we only submit a Green color frame for simplicity.
> More CLs will follow to fill in image data to the compositor
> frame.
>
> BUG=563852
>
> Committed: https://crrev.com/94a3a26405be3996569d9006b29d0460bb9e8dca
> Cr-Commit-Position: refs/heads/master@{#416436}
TBR=junov@chromium.org,danakj@chromium.org,tsepez@chromium.org,sievers@chromi...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=563852
==========
to
==========
Revert of Submit Compositor Frame from OffscreenCanvas on main (patchset #10
id:200001 of https://codereview.chromium.org/2294963002/ )
Reason for revert:
The new OffscreenCanvas-commit-main tests are broken on MSAN on Linux:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/b...
Reason: use-of-uninitialized-value
unexpected_failures:
fast/canvas/OffscreenCanvas-commit-main.html
virtual/gpu/fast/canvas/OffscreenCanvas-commit-main.html
virtual/display_list_2d_canvas/fast/canvas/OffscreenCanvas-commit-main.html
Original issue's description:
> Submit Compositor Frame from OffscreenCanvas on main
>
> CompositorFrame is to be submitted from OffscreenCanvas from
> either main or worker thread (but not both at the same time);
> therefore, another interface "OffscreenCanvasFrameReceiver"
> is created only when commit() is invoked.
>
> This CL follows the class design structure in this diagram:
> www.lucidchart.com/documents/view/346a55cc-0ab1-48e8-9d34-90f59d36094e
>
> Currently, we only submit a Green color frame for simplicity.
> More CLs will follow to fill in image data to the compositor
> frame.
>
> BUG=563852
>
> Committed: https://crrev.com/94a3a26405be3996569d9006b29d0460bb9e8dca
> Cr-Commit-Position: refs/heads/master@{#416436}
TBR=junov@chromium.org,danakj@chromium.org,tsepez@chromium.org,sievers@chromi...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=563852
==========
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago
(2016-09-05 06:07:35 UTC)
#5
Message was sent while issue was closed.
Committed patchset #1 (id:1)
commit-bot: I haz the power
Description was changed from ========== Revert of Submit Compositor Frame from OffscreenCanvas on main (patchset ...
4 years, 3 months ago
(2016-09-05 06:11:02 UTC)
#6
Message was sent while issue was closed.
Description was changed from
==========
Revert of Submit Compositor Frame from OffscreenCanvas on main (patchset #10
id:200001 of https://codereview.chromium.org/2294963002/ )
Reason for revert:
The new OffscreenCanvas-commit-main tests are broken on MSAN on Linux:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/b...
Reason: use-of-uninitialized-value
unexpected_failures:
fast/canvas/OffscreenCanvas-commit-main.html
virtual/gpu/fast/canvas/OffscreenCanvas-commit-main.html
virtual/display_list_2d_canvas/fast/canvas/OffscreenCanvas-commit-main.html
Original issue's description:
> Submit Compositor Frame from OffscreenCanvas on main
>
> CompositorFrame is to be submitted from OffscreenCanvas from
> either main or worker thread (but not both at the same time);
> therefore, another interface "OffscreenCanvasFrameReceiver"
> is created only when commit() is invoked.
>
> This CL follows the class design structure in this diagram:
> www.lucidchart.com/documents/view/346a55cc-0ab1-48e8-9d34-90f59d36094e
>
> Currently, we only submit a Green color frame for simplicity.
> More CLs will follow to fill in image data to the compositor
> frame.
>
> BUG=563852
>
> Committed: https://crrev.com/94a3a26405be3996569d9006b29d0460bb9e8dca
> Cr-Commit-Position: refs/heads/master@{#416436}
TBR=junov@chromium.org,danakj@chromium.org,tsepez@chromium.org,sievers@chromi...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=563852
==========
to
==========
Revert of Submit Compositor Frame from OffscreenCanvas on main (patchset #10
id:200001 of https://codereview.chromium.org/2294963002/ )
Reason for revert:
The new OffscreenCanvas-commit-main tests are broken on MSAN on Linux:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/b...
Reason: use-of-uninitialized-value
unexpected_failures:
fast/canvas/OffscreenCanvas-commit-main.html
virtual/gpu/fast/canvas/OffscreenCanvas-commit-main.html
virtual/display_list_2d_canvas/fast/canvas/OffscreenCanvas-commit-main.html
Original issue's description:
> Submit Compositor Frame from OffscreenCanvas on main
>
> CompositorFrame is to be submitted from OffscreenCanvas from
> either main or worker thread (but not both at the same time);
> therefore, another interface "OffscreenCanvasFrameReceiver"
> is created only when commit() is invoked.
>
> This CL follows the class design structure in this diagram:
> www.lucidchart.com/documents/view/346a55cc-0ab1-48e8-9d34-90f59d36094e
>
> Currently, we only submit a Green color frame for simplicity.
> More CLs will follow to fill in image data to the compositor
> frame.
>
> BUG=563852
>
> Committed: https://crrev.com/94a3a26405be3996569d9006b29d0460bb9e8dca
> Cr-Commit-Position: refs/heads/master@{#416436}
TBR=junov@chromium.org,danakj@chromium.org,tsepez@chromium.org,sievers@chromi...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=563852
Committed: https://crrev.com/ab7f06aeaff3d24a161eb1bbfa246839a362525f
Cr-Commit-Position: refs/heads/master@{#416503}
==========
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ab7f06aeaff3d24a161eb1bbfa246839a362525f Cr-Commit-Position: refs/heads/master@{#416503}
4 years, 3 months ago
(2016-09-05 06:11:03 UTC)
#7
Issue 2313533002: Revert of Submit Compositor Frame from OffscreenCanvas on main
(Closed)
Created 4 years, 3 months ago by Matt Giuca
Modified 4 years, 3 months ago
Reviewers: Justin Novosad, danakj, Tom Sepez, no sievers, xlai (Olivia)
Base URL:
Comments: 0